49295[BUGFIX] Use special treatment for language field in RelationHandler
Commit message
Review
-
Code review CR +2
- Oliver Hader +2
- Markus Klein +1
-
Verified V +2
- Oliver Hader +2
- TYPO3com +1 CI
Files 3
Review log 2937
Show 1012 earlier messages
-
Markus Mächler uploaded patch set 1 08/02/16, 07:19
-
TYPO3com voted on patch set 1 V +1 08/02/16, 07:23 Completed build in 04m 10s on Tue, 2 Aug, 09:23 AM Test Summary: 19380 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1549
-
Markus Klein commented on patch set 1 08/02/16, 08:57
be_groups.php:205This is a feature and can therefore only go in master branch. Of course appropriate documentation is required (RST). -
Markus Mächler uploaded patch set 2 08/02/16, 09:23
-
TYPO3com voted on patch set 2 V +1 08/02/16, 09:31 Completed build in 08m 23s on Tue, 2 Aug, 11:31 AM Test Summary: 19380 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1565
-
Oliver Hader commented on patch set 2 CR -1 08/02/16, 09:34
I'd opt to have tests for that and also to avoid cluttering specific TCA checks among the core... I'm going to have a look into that. -
Markus Mächler commented on patch set 2 08/02/16, 09:38
> I'd opt to have tests for that and also to avoid cluttering > specific TCA checks among the core... I'm going to have a look into > that. true, I tried to introduce a configuration option for allowing empty Ids, which was rejected to be included into 7.6 since it is a new feature. therefore I included the specific check to avoid having to introduce new features. moreover, the sys_language table should be the only place with a zero-valued uid.be_groups.php:205Replyhow else should I do it to have it in TYPO3 7.6? This is a bug and needs to be fixed. -
Susi Moog commented on patch set 2 08/02/16, 10:17
As the analysis in the ticket states this is actually an issue not only concerning languages but datahandler handling/storing empty values therefor I'd prefer a more general solution here. I can dimly remember having the same problem with a "normal" select field not too long ago, but I can't actually find the issue again. -
Markus Mächler commented on patch set 2 08/02/16, 13:38
so how do you want to proceed? -
Markus Klein commented on patch set 2 08/09/16, 10:46
@Olly: In according to my analysis in the ticket we fail hard here on storing 0 in foreign_table situations. Since languages are special anyway we need to the check for this specialty anyways. I had to add such checks at other places too. I would agree to fix it for the given case with the proposed fix and to add generic processing of 0 with foreign table at a later point. -
Markus Klein updated the commit message in patch set 3 08/09/16, 10:48
-
Markus Klein updated the commit message in patch set 4 08/09/16, 10:48
-
Markus Klein voted on patch set 4 CR +1 08/09/16, 10:48
-
TYPO3com voted on patch set 3 V +1 08/09/16, 10:55 Completed build in 06m 39s on Tue, 9 Aug, 12:55 PM Test Summary: 18474 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1951
-
TYPO3com voted on patch set 4 V +1 08/09/16, 10:58 Completed build in 09m 38s on Tue, 9 Aug, 12:58 PM Test Summary: 18474 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1952
-
Daniel Goerz voted on patch set 4 CR +1 V +1 08/10/16, 16:06
-
Oliver Hader uploaded patch set 5 08/15/16, 14:17
-
Oliver Hader voted on patch set 5 CR +1 V +1 08/15/16, 14:18
-
TYPO3com voted on patch set 5 V -1 08/15/16, 14:20 Completed build in 02m 52s on Mon, 15 Aug, 04:20 PM Test Summary: 18690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2062
-
Oliver Hader uploaded patch set 6 08/15/16, 14:22
-
Markus Mächler commented on patch set 5 08/15/16, 14:23
> Uploaded patch set 5. hey oliver the double isset ternary operator does not work for PHP7, therefore for typo3 7.6 you need to use isset()RelationHandler.php:415this is a PHP7 feature, therefore not applicable for 7.6, why don't you just use isset() || ==? https://wiki.php.net/rfc/isset_ternary -
TYPO3com voted on patch set 6 V +1 08/15/16, 14:25 Completed build in 02m 54s on Mon, 15 Aug, 04:25 PM Test Summary: 18690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2063
-
Oliver Hader commented on patch set 6 08/15/16, 14:26
I guess you mean "not for PHP 5.5" which is correct. However, this patch is for master and thus for PHP7... Back-port is a different thing -
Markus Mächler commented on patch set 6 08/15/16, 14:27
ah, ok, thanks for your effort! -
Oliver Hader uploaded patch set 7 08/15/16, 14:32
-
Oliver Hader commented on patch set 6 08/15/16, 14:32
Reduced test case a bit by using data-provider -
Oliver Hader voted on patch set 7 CR +1 V +1 08/15/16, 14:33
-
TYPO3com voted on patch set 7 V +1 08/15/16, 14:35 Completed build in 03m 19s on Mon, 15 Aug, 04:35 PM Test Summary: 18690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2064
-
Oliver Hader commented on patch set 7 CR -1 08/15/16, 14:39
Sorry, forgot something to amend -
Oliver Hader uploaded patch set 8 08/15/16, 14:41
-
Oliver Hader commented on patch set 8 CR +1 V +1 08/15/16, 14:41
Finally... ;-) -
TYPO3com voted on patch set 8 V +1 08/15/16, 14:44 Completed build in 02m 37s on Mon, 15 Aug, 04:44 PM Test Summary: 18690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2066
-
Benni Mack commented on patch set 8 08/15/16, 14:46
please be aware that ?? is PHP7 only http://php.net/manual/de/migration70.new-features.php -
Oliver Hader commented on patch set 8 08/15/16, 14:50
Benni, sure, read comments some minutes ago please -
Markus Klein voted on patch set 8 CR +1 08/15/16, 15:04
-
Oliver Hader voted on patch set 8 CR +2 V +2 08/15/16, 15:17
-
Gerrit merged patch set 8 08/15/16, 15:17
RelationHandler.php:410