Review main Merged

49426[TASK] Doctrine: Migrate a simple upgrade wizard

Christian Kuhn CR +2 V +2 Normal +43 −109 updated 08/09/16, 13:24

Commit message

Migrate a simple install tool upgrade wizard that performs
an update query on be_users.
The upgrade wizard have a feature to display performed queries.
Usually, with doctrine, values would be prepared statement
values and getSQL() would display a placeholder only.
This is worked around here giving set() the third parameter
boolean false and quoting manually.

For the wizards itself, there are two nearly identical ones,
the patch merges both and improves the detection if an
execution is needed an no longer relies on "was executed once"
flag.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3