Review main Merged Breaking

49470[!!!][TASK] Extbase: Remove preparsing of queries

Benni Mack CR +2 V +2 Hard +103 −315 updated 08/16/16, 11:07

Commit message

The whole concept of having placeholders is a pseudo-prepared
statement idea, which RDBMS do inside their query cache. The logic
inside PHP is therefore removed.

The following public methods have been removed:
* Typo3DbBackend->quoteTextValueCallback()
* Typo3DbQueryParser->preparseQuery()
* Typo3DbQueryParser->normalizeParameterIdentifier()
* Typo3DbQueryParser->addDynamicQueryParts()
* ComparisonInterface->setParameterIdentifier
* ComparisonInterface->getParameterIdentifier

The following methods have been marked as deprecated:
* Comparison->setParameterIdentifier()
* Comparison->getParameterIdentifier()

This patch is one of the prerequisites to introduce the Doctrine DBAL
QueryBuilder instead of building raw SQL statements.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 8