Review main Merged

49585[TASK] Doctrine: Migrate SqlSchemaMigrationService

Christian Kuhn CR +2 V +2 Expert +1398 −247 updated 09/01/16, 16:54

Commit message

The schema migration service has some parts that are ext:dbal
specific which can not be mimik'ed easily at the moment.
To still proceed with the doctrine migration, the original
class is copied over to ext:dbal and registiered as xclass,
while a low-level migration is applied to ext:install
SqlSchemaMigrationService.
This way, the schema migration and load order for now works
with both ext:dbal loaded and not loaded within install tool.
The patch further prepares isolation of ext:dbal and dropping
of a bootstrap database method.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 6