Review main Merged

49732[BUGFIX] Fix offset issue with maxSingleDBListItems

Wouter Wolters CR +2 V +2 Easy +2 −2 updated 09/02/16, 08:07

Commit message

There is a + 1 that makes the limit always one higher than
the set value in maxSingleDBListItems.

Review

  • Code review CR +2
    • Morton Jonuschat +2
    • Daniel Goerz +1
    • Stefan Froemken +1
  • Verified V +2
    • Morton Jonuschat +2
    • Daniel Goerz +1
    • Stefan Froemken +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Wouter Wolters uploaded patch set 1 09/01/16, 18:23

  2. TYPO3com voted on patch set 1 V +1 09/01/16, 18:27 Completed build in 03m 41s on Thu, 1 Sep, 08:27 PM Test Summary: 19124 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2669

  3. Daniel Goerz voted on patch set 1 CR +1 V +1 09/01/16, 19:58

  4. Stefan Froemken commented on patch set 1 CR +1 V +1 09/01/16, 20:47

    In prior versions the + 1 was needed for sorting on pages > 1. As this method was not needed by core anymore this change is OK for me.
  5. Morton Jonuschat voted on patch set 1 CR +2 V +2 09/02/16, 08:07

  6. Gerrit merged patch set 1 09/02/16, 08:07