Review main Merged

4974[BUGFIX] Don't add uid,pid if <table>.'*' is present in field list.

Björn Pedersen CR +2 V +2 Normal +42 −9 updated 06/03/13, 20:49

Commit message

tx_cal_tsservice uses queries with select <tablename>.* and
complex joins. This breaks due to the unconditionl adding of uid,pid
if the query is set.

Do not add uid,pid,... to field list if the field list already contains a
'*' or the repective field is in the list.

To keep the code easier to read, the sanitizing has been moved
to a seperate function.

The regexp matching is necessary to  detect fields like post_uid
(comments extension).

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 1