49757[TASK] Show TYPO3 version in system information toolbar item
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Ralf Merz +1
- Michael Oehlhof +1
- Daniel Goerz +1
- Nicole Hummel +1
- Matthias Vogel +1
-
Verified V +2
- Stefan Neufeind +2
- Ralf Merz +1
- Michael Oehlhof +1
- Daniel Goerz +1
- Nicole Hummel +1
- TYPO3com +1 CI
Issues 1
Files 4
Review log 4045
Show 1820 earlier messages
-
Markus Hölzle uploaded patch set 1 09/02/16, 13:13
-
TYPO3com voted on patch set 1 V +1 09/02/16, 13:16 Completed build in 03m 10s on Fri, 2 Sep, 03:16 PM Test Summary: 18499 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2736
-
Matthias Vogel voted on patch set 1 CR +1 09/02/16, 13:18
-
Daniel Goerz commented on patch set 1 CR +1 V +1 09/02/16, 13:40
Wouldn't hurt to backport this "feature" IMHO. -
Andreas Kienast commented on patch set 1 09/02/16, 13:45
Don't you already see the version number on the top left side? -
Markus Hölzle commented on patch set 1 09/02/16, 13:54
If a user wants to make a quick screenshot with all important information he forgets the version. This happened in the past sometimes, so i thought this will be a good idea :-) -
Sascha Egerer uploaded patch set 2 09/02/16, 15:40
-
Sascha Egerer commented on patch set 1 CR +1 V +1 09/02/16, 15:42
Could you please create a ticket to exchange the logo with a "white" version? -
Sascha Egerer voted on patch set 2 CR +1 V +1 09/02/16, 15:46
-
Markus Hölzle voted on patch set 2 CR +1 V +1 09/02/16, 16:12
-
Daniel Goerz voted on patch set 2 CR +1 V +1 09/02/16, 16:21
-
Andreas Kienast commented on patch set 2 CR -1 09/02/16, 16:47
Sorry for killing the upvotes, but the ReST document describing the feature is missing. -
Daniel Goerz commented on patch set 2 09/02/16, 17:00
In my opinion this is not a feature at all. What do you want to write in the rst that goes beyond the commit message? :) -
Andreas Kienast updated the commit message in patch set 3 09/02/16, 17:03
-
Andreas Kienast commented on patch set 3 CR +1 V +1 09/02/16, 17:04
Works, but I'm not quite sure about the grey TYPO3 icon. IMO it should be also white. -
Daniel Goerz voted on patch set 3 CR +1 V +1 09/02/16, 17:05
-
Riccardo De Contardi commented on patch set 3 V +1 09/02/16, 17:08
I agree, the icon should be brighter (#ddd as the text) -
Georg Ringer rebased onto patch set 4 09/03/16, 15:42
-
TYPO3com voted on patch set 4 V +1 09/03/16, 15:46 Completed build in 03m 14s on Sat, 3 Sep, 05:46 PM Test Summary: 18506 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2938
-
Georg Ringer voted on patch set 4 CR +1 V +1 09/03/16, 18:36
-
Christian Kuhn commented on patch set 4 09/04/16, 09:45
fine with the patch in general. however, i think the icon should be white like all the others in the column. maybe this could be improved a bit. -
Christian Kuhn commented on patch set 4 09/04/16, 09:46
maybe andreas fernandez or frank or benji could help on the icon color thing. -
Markus Hölzle uploaded patch set 5 09/04/16, 17:27
-
TYPO3com voted on patch set 5 V +1 09/04/16, 17:30 Completed build in 03m 28s on Sun, 4 Sep, 07:30 PM Test Summary: 18507 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2981
-
Ralf Merz voted on patch set 5 CR +1 V +1 09/04/16, 19:41
-
Sascha Egerer commented on patch set 5 CR -1 09/05/16, 09:47
IconRegistry.php:2476There should be a dash between typo3 and verison. But i think it would make more sense to use a more generic name as you can use that icon on other places, too. What so you think? -
Markus Hölzle uploaded patch set 6 09/06/16, 17:41
-
TYPO3com voted on patch set 6 V +1 09/06/16, 17:44 Completed build in 03m 06s on Tue, 6 Sep, 07:44 PM Test Summary: 18507 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3007
-
Riccardo De Contardi voted on patch set 6 V +1 09/06/16, 19:39
-
Ralf Merz voted on patch set 6 CR +1 V +1 09/07/16, 05:27
-
Matthias Vogel voted on patch set 6 CR +1 09/07/16, 05:51
-
Frans Saris voted on patch set 6 CR +1 V +1 09/07/16, 06:12
-
Nicole Hummel uploaded patch set 7 09/08/16, 22:00
-
Nicole Hummel commented on patch set 7 CR +1 V +1 09/08/16, 22:00
I scaled the icon down to fit better to the other icons. -
TYPO3com voted on patch set 7 V +1 09/08/16, 22:04 Completed build in 03m 58s on Fri, 9 Sep, 12:04 AM Test Summary: 18507 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3021
-
Ralf Merz commented on patch set 7 CR +1 V +1 09/09/16, 07:20
looks better, yes. -
Michael Oehlhof voted on patch set 7 CR +1 V +1 09/09/16, 14:22
-
Daniel Goerz voted on patch set 7 CR +1 V +1 09/09/16, 15:02
-
Riccardo De Contardi voted on patch set 7 V +1 09/09/16, 15:15
-
Matthias Vogel voted on patch set 7 CR +1 09/09/16, 15:18
-
Riccardo De Contardi commented on patch set 7 V 0 09/09/16, 15:23
just for my curiosity: the version infos will be removed from the left part of the top area (I mean: just after the [SYS][sitename]?) -
Daniel Goerz commented on patch set 7 09/09/16, 15:24
No, I think this patch is all about showing them in an additional place where it makes sense, too. -
Christian Kuhn commented on patch set 7 09/09/16, 16:14
well, actually, i think it would be better to remove the version information from the top bar next to the logo (later with second patch). this could also be beneficial if the view port change is done. it is mostly a rather obsolete information for editors anyway, so i tend to kick it for the sake of a clean interface. -
Stefan Neufeind commented on patch set 7 CR +2 V +2 09/19/16, 08:38
ack, let's have it in there. push a separate patch to remove it in the top-title please. -
Gerrit merged patch set 7 09/19/16, 08:38