Review main Merged

49759[TASK] Optimized rendering of Changelogs for docs.typo3.org

Ernesto Baschny CR +2 V +2 Nightmare +2379 −1451 updated 09/03/16, 13:47

Commit message

* Added Index.rst for 8.4-dev
* Updated release number to 8
* Enhanced Index.rst rendering and structure to be in line with
  new theme of docs.typo3.org
* Added Includes.txt for custom renderers
* Make Settings.cfg file more complete
* Tuned indenting in several places
* Removed some ReST syntax errors
  (WARNING: Inline literal start-string without end-string)
  (ERROR: Malformed table)
  (ERROR: Error in "code-block" directive)

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Daniel Goerz +1
    • Tymoteusz Motylewski +1
    • Andreas Kienast +1
  • Verified V +2
    • Wouter Wolters +2
    • Daniel Goerz +1
    • Ernesto Baschny +1

Issues 1

Files 299

Show 279 more files

Review log 1821

  1. Ernesto Baschny uploaded patch set 1 09/02/16, 13:33

  2. Ernesto Baschny commented on patch set 1 09/02/16, 13:34

    For your convenience you can see the result of this change by comparing the rendering: New: http://mockups.cron.eu/typo3/changelog/Index.html Old / Current: https://docs.typo3.org/typo3cms/extensions/core/latest/
  3. TYPO3com voted on patch set 1 V +1 09/02/16, 13:37 Completed build in 03m 31s on Fri, 2 Sep, 03:37 PM Test Summary: 18499 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2738

  4. Ernesto Baschny uploaded patch set 2 09/02/16, 14:08

  5. TYPO3com voted on patch set 2 V +1 09/02/16, 14:11 Completed build in 03m 12s on Fri, 2 Sep, 04:11 PM Test Summary: 18499 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2742

  6. Martin Bless uploaded patch set 3 09/02/16, 14:41

  7. TYPO3com voted on patch set 3 V +1 09/02/16, 14:44 Completed build in 03m 02s on Fri, 2 Sep, 04:44 PM Test Summary: 18501 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2747

  8. Martin Bless commented on patch set 3 CR +1 V +1 09/02/16, 14:46

    In patchset 3 we get rid of those double backticks. Many many wrong constructions like :php:``...`` automatically become right through that. And single backticks are better anyway. Wow, this is in a rather brilliant state now!
  9. Tymoteusz Motylewski commented on patch set 3 09/02/16, 16:13

    Breaking-77062-ExampleImageInTSConstantsDescriptionsRemoved.rst:22

    this should also by :php: right?

    Breaking-77180-DroppedExtJSSupportInFrontendTypoScript.rst:13

    should it be '.. code-block:: ts' ?
  10. Ernesto Baschny commented on patch set 3 09/02/16, 16:37

    Breaking-77062-ExampleImageInTSConstantsDescriptionsRemoved.rst:22 Reply

    yes, sir! good catch, was wrong before already.

    Breaking-77180-DroppedExtJSSupportInFrontendTypoScript.rst:10

  11. Martin Bless commented on patch set 3 09/02/16, 17:49

    To help understanding: Pygments is a commandline tool. Knows a lexer 'typoscript' So you can only use 'typoscript' in .. code-block:: directives. Run "pygmentize -L" at the commandline to see what's available. 'ts' and 'typoscript' are textroles leading to a CSS class 'typoscript' because we define that in Includes.txt.
  12. Ernesto Baschny uploaded patch set 4 09/02/16, 20:48

  13. Wouter Wolters commented on patch set 4 CR +1 09/02/16, 22:32

    IMO go ahead.
  14. Tymoteusz Motylewski commented on patch set 4 CR +1 09/03/16, 07:55

    not sure how to test it
  15. Daniel Goerz voted on patch set 4 CR +1 09/03/16, 08:54

  16. Ernesto Baschny commented on patch set 4 V +1 09/03/16, 08:58

    Just compare the current rendered one with the new one: http://mockups.cron.eu/typo3/changelog/Index.html vs https://docs.typo3.org/typo3cms/extensions/core/latest/ As soon as this is merged, the new changelog will be rendered at the official location.

    Breaking-77062-ExampleImageInTSConstantsDescriptionsRemoved.rst:22 Reply

    Done
  17. Ernesto Baschny commented on patch set 4 09/03/16, 08:59

    If anyone is interested in the requirements to compile these files to see it by themselves, get in touch...
  18. Daniel Goerz voted on patch set 4 V +1 09/03/16, 09:13

  19. Andreas Kienast voted on patch set 4 CR +1 09/03/16, 09:14

  20. Wouter Wolters voted on patch set 4 CR +2 V +2 09/03/16, 13:47

  21. Gerrit merged patch set 4 09/03/16, 13:47