Review main Merged

49778[BUGFIX] Fix check if LocalConfiguration.php is writeable

Johannes Goslar CR +2 V +2 Easy +1 −1 updated 09/03/16, 15:59

Commit message

If the file exists, we only need to check if it is writeable, but do not
need to care for the folder write permissions (which are only required
to create a new file).

Review

  • Code review CR +2
    • Andreas Wolf +2
  • Verified V +2
    • Andreas Wolf +2

Files 1

Review log 7

  1. Johannes Goslar uploaded patch set 1 09/02/16, 18:36

  2. Peter Foerger voted on patch set 1 CR +1 V +1 09/02/16, 18:39

  3. Mathias Schreiber commented on patch set 1 CR +1 09/02/16, 18:50

    Showing off to the crowd at T3DD16 (still looks good, though)
  4. Andreas Wolf updated the commit message in patch set 2 09/02/16, 20:25

  5. Andreas Wolf voted on patch set 2 CR +2 V +2 09/02/16, 20:26

  6. Gerrit merged patch set 2 09/02/16, 20:26

  7. Tymoteusz Motylewski commented on patch set 3 09/03/16, 15:59

    post -1, unit test is failing ./bin/phpunit -c typo3/sysext/core/Build/UnitTests.xml typo3/sysext/core/Tests/Unit/Configuration/ConfigurationManagerTest.php