Review main Abandoned

49796[TASK] Remove not required where condition

Volker Kemeter CR 0 V 0 Easy +0 −1 updated 12/31/16, 04:38

Commit message

Remove where condition from DatabaseSystemLanguageRows.php

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 8

  1. Volker Kemeter uploaded patch set 1 09/02/16, 20:37

  2. Marco Huber voted on patch set 1 CR +1 V +1 09/02/16, 20:53

  3. Morton Jonuschat commented on patch set 1 CR -1 09/02/16, 21:35

    I would like to keep that constraint in. it ensures the TCA rootlevel configuration and just because you're not allowed to save something from the UI doesn't mean records can not be inserted by other means.
  4. Marc von Schalscha commented on patch set 1 CR -1 09/03/16, 09:44

    I fully agree with Morton.
  5. Marco Huber commented on patch set 1 09/03/16, 14:20

    Why should we care about, where the sys_language record is stored? I think it's not important in this query. So I think, we can remove the where clause. And - ok I know this is no argument ;-) - in other similar queries there is no check for the pid, too. (f.e. \TYPO3\CMS\Backend\Controller\NewRecordController::checkIfLanguagesExist or \TYPO3\CMS\Backend\View\PageLayoutView::languageSelector) If we want to take care about the pid, we should check the TCA and only add the where close if 'rootlevel' is set. But then we should do this in every place.
  6. Morton Jonuschat commented on patch set 1 09/03/16, 15:37

    As discussed during lunch it's better to fix the „incomplete“ statements (and switch to the RootLevelRestriction where possible) instead of dropping the constraint here as well.
  7. Morton Jonuschat commented on patch set 1 12/05/16, 07:17

    Hey Volker, wanna pick this up again or should be abandon the patchset for now?
  8. Morton Jonuschat abandoned the change 12/31/16, 04:38

    no feedback/activity