Review main Merged

49819[TASK] Use general utility to build html attribute string

Sascha Egerer CR +2 V +2 Easy +2 −7 updated 09/10/17, 10:30

Commit message

There was one leftover place, where an attributes string was
concatenated instead using the helper function.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Joerg Kummer +1
  • Verified V +2
    • Christian Kuhn +2
    • Joerg Kummer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 3953

Show 2128 earlier messages
  1. Sascha Egerer uploaded patch set 1 09/03/16, 08:37

  2. TYPO3com voted on patch set 1 V -1 09/03/16, 08:40 Completed build in 03m 19s on Sat, 3 Sep, 10:40 AM Test Summary: 18506 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2843

  3. Sascha Egerer updated the commit message in patch set 2 09/03/16, 09:07

  4. Sascha Egerer commented on patch set 2 09/03/16, 09:07

    just repusht because of bamboo hickup
  5. Andreas Kienast commented on patch set 2 09/03/16, 09:09

    It's not a hickup, please run ./typo3/sysext/core/Build/Scripts/cglFixMyCommit.sh :)
  6. TYPO3com voted on patch set 2 V -1 09/03/16, 09:10 Completed build in 03m 07s on Sat, 3 Sep, 11:10 AM Test Summary: 18506 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2848

  7. Andreas Kienast uploaded patch set 3 09/03/16, 09:11

  8. TYPO3com voted on patch set 3 V +1 09/03/16, 09:15 Completed build in 03m 06s on Sat, 3 Sep, 11:14 AM Test Summary: 18506 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2851

  9. Ralf Merz commented on patch set 3 09/03/16, 10:21

    InputColorPickerElement.php:128

    Could this not also be written in one line? And the comment "Build the attribute string" can also be removed here. $html = '<input type="text" ' . GeneralUtility::implodeAttributes($attributes, true, true) . ' />';
  10. Sascha Egerer uploaded patch set 4 09/03/16, 10:24

  11. Sascha Egerer uploaded patch set 5 09/03/16, 10:25

  12. TYPO3com voted on patch set 4 V -1 09/03/16, 10:27 Completed build in 03m 05s on Sat, 3 Sep, 12:27 PM Test Summary: 18506 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2866

  13. Ralf Merz voted on patch set 5 CR +1 V +1 09/03/16, 10:27

  14. Tymoteusz Motylewski commented on patch set 4 09/03/16, 10:27

    InputColorPickerElement.php:124

    whitespaces
  15. Sascha Egerer commented on patch set 5 09/03/16, 10:28

    you where to slow ;-)
  16. TYPO3com voted on patch set 5 V -1 09/03/16, 10:28 Completed build in 02m 53s on Sat, 3 Sep, 12:28 PM Test Summary: 18506 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2868

  17. Sascha Egerer updated the commit message in patch set 6 09/03/16, 11:49

  18. Sascha Egerer uploaded patch set 7 09/03/16, 11:52

  19. TYPO3com voted on patch set 6 V -1 09/03/16, 11:53 Completed build in 03m 14s on Sat, 3 Sep, 01:53 PM Test Summary: 18506 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2879

  20. TYPO3com voted on patch set 7 V +1 09/03/16, 11:55 Completed build in 03m 07s on Sat, 3 Sep, 01:55 PM Test Summary: 18506 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2880

  21. Ralf Merz voted on patch set 7 CR +1 V +1 09/04/16, 16:58

  22. Michael Oehlhof voted on patch set 7 CR +1 09/13/16, 08:04

  23. Benni Mack commented on patch set 7 09/13/16, 09:47

    SelectSingleBoxElement.php:233

    the implodeAttributes of GeneralUtility does not call hsc with the options above. we should handle this with tests if possible?
  24. Stefan Neufeind commented on patch set 7 09/19/16, 08:09

    GeneralUtility
  25. Frank Nägler commented on patch set 7 CR -1 10/21/16, 14:05

    SelectSingleBoxElement.php:158

    implodeAttributes has only 3 params, not 4!

    SelectSingleBoxElement.php:177

    implodeAttributes has only 3 params, not 4!

    SelectSingleBoxElement.php:212

    implodeAttributes has only 3 params, not 4!
  26. Stefan Neufeind commented on patch set 7 10/21/16, 14:37

    SelectSingleBoxElement.php:158 Reply

    This patch also adds the (optional) fourth parameter!
  27. Frank Nägler commented on patch set 7 11/07/16, 14:06

    thx for the hint about the new fourth argument, I missed that. Anyway, adding new a argument is a feature and not a cleanup patch. please add a rst file and change the patch type to FEATURE.
  28. Benni Mack commented on patch set 7 11/09/16, 06:56

    I wonder if we need the 4th parameter or if we can have it enabled all the time (sounds like Unit Tests for GeneralUtility :))
  1. Anja Leichsenring uploaded patch set 8 12/04/16, 11:01

  2. Anja Leichsenring commented on patch set 8 CR -1 12/04/16, 11:02

    rebased only, Franks comments still apply. Unit tests would be a benefit.
  3. Ralf Merz voted on patch set 8 CR +1 12/04/16, 11:03

  4. Anja Leichsenring updated the commit message in patch set 9 12/04/16, 11:04

  5. Anja Leichsenring commented on patch set 9 CR -1 12/04/16, 11:04

    feature rst and Unit Tests missing
  6. TYPO3com voted on patch set 9 V -1 12/04/16, 11:42 Completed build in 38m 09s on Sun, 4 Dec, 12:42 PM Test Summary: 54322 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5485

  7. Anja Leichsenring uploaded patch set 10 09/10/17, 08:25

  8. Anja Leichsenring uploaded patch set 11 09/10/17, 08:28

  9. TYPO3com voted on patch set 11 V -1 09/10/17, 08:28 Completed build in 09s on Sun, 10 Sep, 10:28 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14778

  10. Anja Leichsenring uploaded patch set 12 09/10/17, 08:29

  11. Anja Leichsenring commented on patch set 11 CR +1 V +1 09/10/17, 08:35

    not so much left :) Lets put this in.
  12. Anja Leichsenring rebased onto patch set 13 09/10/17, 08:35

  13. Anja Leichsenring updated the commit message in patch set 14 09/10/17, 08:36

  14. Anja Leichsenring voted on patch set 14 CR +1 V +1 09/10/17, 08:36

  15. TYPO3com voted on patch set 10 V +1 09/10/17, 08:43 Completed build in 18m 09s on Sun, 10 Sep, 10:43 AM Test Summary: 58140 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14777

  16. TYPO3com voted on patch set 12 V -1 09/10/17, 08:46 Completed build in 17m 45s on Sun, 10 Sep, 10:46 AM Test Summary: 1 of 58503 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14779

  17. TYPO3com voted on patch set 13 V -1 09/10/17, 08:51 Completed build in 15m 29s on Sun, 10 Sep, 10:51 AM Test Summary: 1 of 58503 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14780

  18. TYPO3com voted on patch set 14 V +1 09/10/17, 08:55 Completed build in 18m 37s on Sun, 10 Sep, 10:55 AM Test Summary: 58140 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14781

  19. Christian Kuhn uploaded patch set 15 09/10/17, 09:06

  20. Christian Kuhn voted on patch set 15 CR +1 V +1 09/10/17, 09:06

  21. TYPO3com voted on patch set 15 V +1 09/10/17, 09:25 Completed build in 19m 47s on Sun, 10 Sep, 11:25 AM Test Summary: 58140 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14786

  22. Joerg Kummer voted on patch set 15 CR +1 09/10/17, 10:29

  23. Joerg Kummer voted on patch set 15 V +1 09/10/17, 10:30

  24. Christian Kuhn voted on patch set 15 CR +2 V +2 09/10/17, 10:30

  25. Gerrit merged patch set 15 09/10/17, 10:30