Review main Merged

4983[BUGFIX] t3lib_Compressor: Avoid reference in foreach loop

Frederic Gaus CR +2 V +2 Easy +3 −2 updated 06/03/13, 20:49

Commit message

This fixes a bug introduced in #29695. There is a PHP bug
when using $filename as a reference and later on as a variable in
a foreach loop. The problem is described here:

http://www.php.net/manual/de/control-structures.foreach.php#101425

PHP 5.3.2 (used in current Ubuntu) and 5.3.3 (used in current Debian)
are affected. Other versions could be affected, too.

Avoiding the use of reference in the foreach loop fixes the bug.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 1