Review main Merged Breaking

49906[!!!][TASK] Use correct ISO8601 format

Benjamin Serfhos CR +2 V +2 Easy +19 −5 updated 10/08/16, 18:54

Commit message

DateTime::ISO8601 is not compatible with ISO-8601, but is left this
way for backward compatibility reasons. Use DateTime::ATOM or
DATE_ATOM for compatibility with ISO-8601 instead.

Review

  • Code review CR +2
    • Benni Mack +2
    • Jan Helke +1
  • Verified V +2
    • Benni Mack +2
    • Tomasz Stępniak +1
    • Jan Helke +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1724

  1. Benjamin Serfhos uploaded patch set 1 09/12/16, 15:17

  2. TYPO3com voted on patch set 1 V -1 09/12/16, 15:21 Completed build in 03m 33s on Mon, 12 Sep, 05:21 PM Test Summary: 4 of 18507 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3058

  3. Benni Mack updated the commit message in patch set 2 09/12/16, 15:21

  4. Benjamin Serfhos uploaded patch set 3 09/12/16, 15:22

  5. Benjamin Serfhos updated the commit message in patch set 4 09/12/16, 15:23

  6. TYPO3com voted on patch set 2 V -1 09/12/16, 15:25 Completed build in 03m 54s on Mon, 12 Sep, 05:25 PM Test Summary: 4 of 18507 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3059

  7. TYPO3com voted on patch set 3 V +1 09/12/16, 15:26 Completed build in 04m 23s on Mon, 12 Sep, 05:26 PM Test Summary: 18507 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3060

  8. TYPO3com voted on patch set 4 V +1 09/12/16, 15:28 Completed build in 04m 39s on Mon, 12 Sep, 05:28 PM Test Summary: 18507 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3061

  9. Oliver Hader commented on patch set 4 09/12/16, 22:48

    This might be breaking for client applications that rely on the (wrong ISO) format. At least we should have a breaking RST file for that.
  10. Oliver Hader commented on patch set 4 09/12/16, 22:49

  11. Benjamin Serfhos uploaded patch set 5 09/13/16, 07:32

  12. Andreas Kienast updated the commit message in patch set 6 09/13/16, 07:34

  13. TYPO3com voted on patch set 5 V +1 09/13/16, 07:35 Completed build in 03m 16s on Tue, 13 Sep, 09:35 AM Test Summary: 18507 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3063

  14. TYPO3com voted on patch set 6 V +1 09/13/16, 07:38 Completed build in 03m 33s on Tue, 13 Sep, 09:38 AM Test Summary: 18507 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3064

  15. Frank Nägler voted on patch set 6 CR +1 10/07/16, 11:27

  16. Markus Sommer voted on patch set 6 CR +1 10/07/16, 12:19

  17. Jan Helke voted on patch set 6 CR +1 V +1 10/07/16, 12:40

  18. Tymoteusz Motylewski commented on patch set 6 CR -1 10/07/16, 17:39

    Breaking-77919-ChangedDateTimeISO8601ToDateTimeATOM.rst:6

    issue number link missing See :forge:`77919`
  19. Tymoteusz Motylewski commented on patch set 7 10/07/16, 17:41

    Published edit on patch set 6.
  20. TYPO3com voted on patch set 7 V +1 10/07/16, 17:44 Completed build in 03m 23s on Fri, 7 Oct, 07:44 PM Test Summary: 18545 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3402

  21. Jan Helke voted on patch set 7 CR +1 V +1 10/08/16, 10:15

  22. Tomasz Stępniak voted on patch set 7 V +1 10/08/16, 11:33

  23. Benni Mack voted on patch set 7 CR +2 V +2 10/08/16, 18:54

  24. Gerrit merged patch set 7 10/08/16, 18:54