Review main Merged

50059[BUGFIX] Incorrect cHash generation may cause 404 on any page

Dmitry Dulepov CR +2 V +2 Easy +6 −1 updated 09/30/16, 07:22

Commit message

If an empty parameter appears in the query string passed to
CacheHashCalculator::getRelevantParameters(), the code will
calculate cHash even if there are no other parameters. But
upon going to the generated link, there will be a 404 error
due to failed cHash check. Parameters with trimmed empty
names do not appear in $_GET in PHP and cHash cannot be
validated. The code should ignore the parameter with
trimmed empty name.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2