Review main Merged

50284[BUGFIX] Prevent malformed SQL query in AbstractDatabaseRecordList

Claus Due CR +2 V +2 Easy +2 −2 updated 10/21/16, 12:30

Commit message

This change prevents the creation of a malformed SQL query in
AbstractDatabaseRecordList::makeQueryArray. The problem was
caused by the makeSearchString method returning `1=1` from two
early decisions, whereas before it would return a valid query
prepended with AND but containing no search clauses.

Returning an empty string from these two early decisions will
completely solve the issue without breaking the search feature
that uses this function.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1