Review main Merged

50333[BUGFIX] Authentication service respects deleted-flag

Marc Willmann CR +2 V +2 Normal +86 −1 updated 10/25/16, 13:59

Commit message

Avoids impossible logins due to wrong mappings to old
(deleted) users with the same username as a valid one.

Review

  • Code review CR +2
    • Jan Helke +2
    • Wouter Wolters +1
    • Christian Kuhn +1
    • Mathias Brodala +1
  • Verified V +2
    • Jan Helke +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 3244

Show 1419 earlier messages
  1. Marc Willmann uploaded patch set 1 10/24/16, 11:03

  2. Marc Willmann updated the commit message in patch set 2 10/24/16, 11:04

  3. Marc Willmann updated the commit message in patch set 3 10/24/16, 11:05

  4. Mathias Brodala commented on patch set 3 CR -1 10/24/16, 11:06

    Please see the commit message guidelines: https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/GitSetup/CommitMessageFormat.html (Currently missing the Releases line)
  5. TYPO3com voted on patch set 1 V +1 10/24/16, 11:10 Completed build in 06m 20s on Mon, 24 Oct, 01:10 PM Test Summary: 19561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4044

  6. TYPO3com voted on patch set 2 V +1 10/24/16, 11:11 Completed build in 06m 52s on Mon, 24 Oct, 01:11 PM Test Summary: 19561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4045

  7. TYPO3com voted on patch set 3 V +1 10/24/16, 11:13 Completed build in 07m 44s on Mon, 24 Oct, 01:13 PM Test Summary: 19561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4046

  8. Marc Willmann updated the commit message in patch set 4 10/24/16, 11:14

  9. TYPO3com voted on patch set 4 V +1 10/24/16, 11:20 Completed build in 05m 40s on Mon, 24 Oct, 01:20 PM Test Summary: 19561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4047

  10. Anja Leichsenring voted on patch set 4 CR +1 V +1 10/24/16, 11:52

  11. Mathias Brodala commented on patch set 4 10/24/16, 12:31

    AuthenticationService.php:63

    I wonder if this should be fixed in this method instead to NOT remove the DeletedRestriction. I cannot imagine an authentication workflow which works with deleted user records.
  12. Jan Helke commented on patch set 4 10/24/16, 17:07

    AuthenticationService.php:63 Reply

    That method has nothing to do with the authentication workflow but only fetches the user data. And that should be also possible for deleted users. But I see that problem at a lot of other places to. How will TYPO3 behave if User A creates a page B, than the user was deleted and the new User A inherits the responsibility of the page B.
  13. Jan Helke commented on patch set 4 10/24/16, 17:08

    AuthenticationService.php:63 Reply

    But that thoughts shouldn't block this patch.
  14. Mathias Brodala commented on patch set 4 CR -1 10/25/16, 08:17

    AuthenticationService.php:63

    Please use BackendUtility::deleteClause() for this. If someone disables soft delete, this will fail.
  15. Marc Willmann uploaded patch set 5 10/25/16, 08:37

  16. Anja Leichsenring commented on patch set 5 V -1 10/25/16, 08:38

    on it. hardcoded table name = no go ;)
  17. Marc Willmann commented on patch set 4 10/25/16, 08:38

    good point; but how would that be possible to configure (be_users not to be soft deleted)? BackendUtility::deleteClause() is now used in the code.
  18. TYPO3com voted on patch set 5 V -1 10/25/16, 08:45 Completed build in 08m 18s on Tue, 25 Oct, 10:45 AM Test Summary: 19563 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4116

  19. Mathias Brodala commented on patch set 5 CR -1 10/25/16, 08:59

    Both FrontendUserAuthentication and BackendUserAuthentication define a "user_table" property but that's not really API AFAIS.

    AuthenticationService.php:63

    Please "use" this.
  1. Anja Leichsenring uploaded patch set 6 10/25/16, 10:17

  2. Anja Leichsenring uploaded patch set 7 10/25/16, 10:19

  3. Anja Leichsenring uploaded patch set 8 10/25/16, 10:21

  4. Anja Leichsenring uploaded patch set 9 10/25/16, 10:22

  5. TYPO3com voted on patch set 6 V -1 10/25/16, 10:24 Completed build in 06m 04s on Tue, 25 Oct, 12:24 PM Test Summary: 19563 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4121

  6. TYPO3com voted on patch set 7 V -1 10/25/16, 10:25 Completed build in 05m 49s on Tue, 25 Oct, 12:25 PM Test Summary: 19565 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4122

  7. TYPO3com voted on patch set 8 V -1 10/25/16, 10:29 Completed build in 07m 37s on Tue, 25 Oct, 12:29 PM Test Summary: 19565 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4123

  8. Wouter Wolters commented on patch set 9 10/25/16, 10:30

    AuthenticationServiceTest.php:22

    space too much here, also below.

    AuthenticationServiceTest.php:42

    empty line too much

    AuthenticationServiceTest.php:51

    use lowerCamelCase variables.
  9. TYPO3com voted on patch set 9 V -1 10/25/16, 10:30 Completed build in 07m 52s on Tue, 25 Oct, 12:30 PM Test Summary: 19565 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4124

  10. Anja Leichsenring uploaded patch set 10 10/25/16, 10:31

  11. TYPO3com voted on patch set 10 V +1 10/25/16, 10:37 Completed build in 05m 25s on Tue, 25 Oct, 12:37 PM Test Summary: 19565 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4126

  12. Jan Helke voted on patch set 10 CR +1 10/25/16, 10:41

  13. Mathias Brodala voted on patch set 10 CR +1 10/25/16, 11:13

  14. Jan Helke voted on patch set 10 V +1 10/25/16, 11:23

  15. Wouter Wolters commented on patch set 10 CR -1 10/25/16, 11:24

    My comments still apply to latest patchset.
  16. Anja Leichsenring uploaded patch set 11 10/25/16, 11:32

  17. Jan Helke voted on patch set 11 CR +1 V +1 10/25/16, 11:36

  18. TYPO3com voted on patch set 11 V -1 10/25/16, 11:37 Completed build in 04m 41s on Tue, 25 Oct, 01:37 PM Test Summary: 19565 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4132

  19. Anja Leichsenring uploaded patch set 12 10/25/16, 11:54

  20. TYPO3com voted on patch set 12 V +1 10/25/16, 11:59 Completed build in 05m 01s on Tue, 25 Oct, 01:59 PM Test Summary: 19565 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4135

  21. Wouter Wolters voted on patch set 12 CR +1 10/25/16, 12:04

  22. Mathias Brodala voted on patch set 12 CR +1 10/25/16, 12:35

  23. Christian Kuhn voted on patch set 12 CR +1 V +1 10/25/16, 13:57

  24. Jan Helke voted on patch set 12 CR +2 V +2 10/25/16, 13:58

  25. Gerrit merged patch set 12 10/25/16, 13:59