Review main Merged

50337[BUGFIX] Add type check to prevent error if backend user is null

Marc Willmann CR +2 V +2 Easy +4 −1 updated 10/24/16, 21:13

Commit message

$backendUser may be null, this would cause an error. Add an
additional type check to prevent this.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Jörg Bösche +1
  • Verified V +2
    • Wouter Wolters +2
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1316

  1. Marc Willmann uploaded patch set 1 10/24/16, 12:21

  2. Andreas Kienast commented on patch set 1 10/24/16, 12:26

    Avatar.php:82

    Personally, I prefer `$backendUser !== null`
  3. TYPO3com voted on patch set 1 V +1 10/24/16, 12:27 Completed build in 05m 40s on Mon, 24 Oct, 02:27 PM Test Summary: 19561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4059

  4. Wouter Wolters commented on patch set 1 10/24/16, 12:28

    Avatar.php:82 Reply

    which is also faster. +1 to change this as suggested by Andy.
  5. Marc Willmann uploaded patch set 2 10/24/16, 12:30

  6. Wouter Wolters voted on patch set 2 CR +1 10/24/16, 12:35

  7. TYPO3com voted on patch set 2 V +1 10/24/16, 12:35 Completed build in 05m 03s on Mon, 24 Oct, 02:35 PM Test Summary: 19561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4060

  8. Andreas Kienast voted on patch set 2 CR +1 10/24/16, 12:42

  9. Jörg Bösche voted on patch set 2 CR +1 V +1 10/24/16, 20:11

  10. Wouter Wolters commented on patch set 2 CR -1 10/24/16, 20:18

    Avatar.php:83

    now $avatarImage is not defined when $backendUser is null
  11. Wouter Wolters uploaded patch set 3 10/24/16, 20:19

  12. TYPO3com voted on patch set 3 V +1 10/24/16, 20:24 Completed build in 05m 22s on Mon, 24 Oct, 10:24 PM Test Summary: 19563 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4102

  13. Wouter Wolters voted on patch set 3 CR +1 V +1 10/24/16, 20:25

  14. Jörg Bösche voted on patch set 3 CR +1 V +1 10/24/16, 20:31

  15. Wouter Wolters voted on patch set 3 CR +2 V +2 10/24/16, 21:13

  16. Gerrit merged patch set 3 10/24/16, 21:13