Review main Merged

50351[BUGFIX] Report module should not alert when all db tables are utf8

Benni Mack CR +2 V +2 Easy +31 −4 updated 10/25/16, 19:14

Commit message

In case a database default character set is latin1 but all tables
created in the database are utf8, the reports module warns that
the db is configured wrong, which might be the case, but on certain
hosters this is not an excuse. Instead, all TYPO3 tables
are created with a utf8 collation (equiv. to utf8 character set) and
stored correctly, so there is no need to throw a big red box.

The patch extends the utf-8 check to see if all database tables
are utf8 and everything is fine.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1417

  1. Benni Mack uploaded patch set 1 10/24/16, 21:03

  2. TYPO3com voted on patch set 1 V +1 10/24/16, 21:09 Completed build in 05m 28s on Mon, 24 Oct, 11:09 PM Test Summary: 19563 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4103

  3. Michael Stucki commented on patch set 1 10/24/16, 21:23

    Not really a fan of this change. If the default character set is latin1, it means that new tables will also be created with latin1. Wouldn't it be easier to change the database default character set? Or do you think it's not allowed at these hosters? Do you have one particular hoster in mind where this happens?
  4. Benni Mack commented on patch set 1 10/25/16, 08:00

    @stucki: platform.sh ;) they create the DB (mariadb) but we create the tables.
  5. Daniel Windloff commented on patch set 1 10/25/16, 08:10

    Set the severity to warning? It's obviously not a problem at the moment, but could cause problems in the future.
  6. Michael Stucki commented on patch set 1 10/25/16, 08:52

    IMHO it's a bug, either because it should be UTF-8 by default anyway, or otherwise because the user lacks permission to change the default. I won't give -1 but still recommend that you skip this change and inform the hoster instead. They should fix this.
  7. Anja Leichsenring commented on patch set 1 10/25/16, 11:15

    ConfigurationStatus.php:315

    make this a count query?

    ConfigurationStatus.php:325

    I would prefer a warning or info. Silently ignoring the fact of 'wrong' default charset removes the option for the user to inquire his hoster for change.
  8. Benni Mack commented on patch set 1 10/25/16, 15:43

    @Stucki - yes, they "should" fix it, that's what we should tell all hosters ;). However, I would then suggest to remove this report completely, as the migration was done in 4.5 and if someone does this kind of stuff nowadays (DB non-utf8) he is in serious trouble anyways - no need for a reports module.
  9. Anja Leichsenring commented on patch set 1 V -1 10/25/16, 16:32

    on it
  10. Anja Leichsenring uploaded patch set 2 10/25/16, 17:21

  11. Anja Leichsenring commented on patch set 2 CR +1 V +1 10/25/16, 17:22

    works for me now. Please give feedback.
  12. TYPO3com voted on patch set 2 V -1 10/25/16, 17:27 Completed build in 06m 15s on Tue, 25 Oct, 07:27 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4183

  13. Anja Leichsenring uploaded patch set 3 10/25/16, 18:03

  14. Anja Leichsenring voted on patch set 3 CR +1 V +1 10/25/16, 18:04

  15. TYPO3com voted on patch set 3 V +1 10/25/16, 18:09 Completed build in 05m 12s on Tue, 25 Oct, 08:09 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4184

  16. Christian Kuhn voted on patch set 3 CR +2 V +2 10/25/16, 19:14

  17. Gerrit merged patch set 3 10/25/16, 19:14