Review main Merged

50352[BUGFIX] Implement CMS setRenderingContext for AbstractConditionViewHelper

Claus Due CR +2 V +2 Easy +20 −0 updated 10/25/16, 14:30

Commit message

This fixes an issue where the CMS specific overridden
setRenderingContext method on CMS AbstractConditionViewHelper is
not present because the class does not subclass the CMS
AbstractViewHelper (due to coupling concerns). Subsequently the
ControllerContext is not assigned in $this->controllerContext.

This inconsistency is fixed by adding the method just like it
appears in the AbstractViewHelper class, along with declaring
the property containing the ControllerContext.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1