50375[TASK] Acceptance test for Inline 1n from styleguide
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Daniel Gohlke +1
-
Verified V +2
- Christian Kuhn +2
- Daniel Gohlke +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1319
-
Gordon Brüggemann uploaded patch set 1 10/25/16, 19:38
-
TYPO3com voted on patch set 1 V -1 10/25/16, 19:44 Completed build in 05m 38s on Tue, 25 Oct, 09:44 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4188
-
Gordon Brüggemann uploaded patch set 2 10/25/16, 19:47
-
TYPO3com voted on patch set 2 V +1 10/25/16, 19:52 Completed build in 04m 25s on Tue, 25 Oct, 09:52 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4189
-
Daniel Gohlke commented on patch set 2 10/25/16, 20:00
Inline1nCest.php:54You can move this to the _before method. -
Daniel Gohlke voted on patch set 2 CR -1 10/25/16, 20:17
-
Gordon Brüggemann uploaded patch set 3 10/25/16, 20:29
-
TYPO3com voted on patch set 3 V +1 10/25/16, 20:37 Completed build in 07m 18s on Tue, 25 Oct, 10:37 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4190
-
Daniel Gohlke commented on patch set 3 CR -1 10/25/16, 21:09
We can improve the code even further -
Wouter Wolters commented on patch set 3 10/25/16, 21:17
removet one space from here. Forge is not picking up this comment now. -
Gordon Brüggemann uploaded patch set 4 10/25/16, 23:11
-
Gordon Brüggemann updated the commit message in patch set 5 10/25/16, 23:15
-
TYPO3com voted on patch set 4 V +1 10/25/16, 23:18 Completed build in 06m 33s on Wed, 26 Oct, 01:18 AM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4200
-
TYPO3com voted on patch set 5 V +1 10/25/16, 23:21 Completed build in 05m 42s on Wed, 26 Oct, 01:21 AM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4201
-
Gordon Brüggemann uploaded patch set 6 10/26/16, 08:09
-
Daniel Gohlke commented on patch set 6 CR +1 V +1 10/26/16, 08:12
Looks good to me. -
TYPO3com voted on patch set 6 V +1 10/26/16, 08:13 Completed build in 04m 38s on Wed, 26 Oct, 10:13 AM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4205
-
Christian Kuhn voted on patch set 6 CR +2 V +2 10/26/16, 16:47
-
Gerrit merged patch set 6 10/26/16, 16:47
Inline1nCest.php:50