Review main Merged

50407[TASK] Align user dropdown with all others

Georg Ringer CR +2 V +2 Easy +25 −19 updated 11/18/16, 22:21

Commit message

Provide a title in the backend as well for the user dropdown
Furthermore an empty module section is prevented.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Jörg Bösche +1
    • Nicole Hummel +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Jörg Bösche +1
    • Nicole Hummel +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1824

  1. Georg Ringer uploaded patch set 1 10/28/16, 07:11

  2. TYPO3com voted on patch set 1 V +1 10/28/16, 07:15 Completed build in 03m 46s on Fri, 28 Oct, 09:15 AM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4351

  3. Georg Ringer updated the commit message in patch set 2 10/28/16, 09:42

  4. TYPO3com voted on patch set 2 V +1 10/28/16, 09:48 Completed build in 05m 55s on Fri, 28 Oct, 11:48 AM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4359

  5. Daniel Gohlke voted on patch set 2 CR +1 V +1 10/28/16, 10:34

  6. Nicole Hummel uploaded patch set 3 10/28/16, 13:56

  7. Nicole Hummel voted on patch set 3 CR +1 V +1 10/28/16, 13:59

  8. TYPO3com voted on patch set 3 V +1 10/28/16, 14:02 Completed build in 06m 04s on Fri, 28 Oct, 04:02 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4380

  9. Josef Glatz voted on patch set 3 CR +1 V +1 10/28/16, 15:08

  10. Daniel Gohlke voted on patch set 3 CR +1 V +1 10/28/16, 17:30

  11. Georg Ringer commented on patch set 3 10/28/16, 17:39

    UserToolbarItemDropDown.html:8

    no f:then is needed
  12. Wouter Wolters uploaded patch set 4 10/28/16, 18:16

  13. Wouter Wolters commented on patch set 4 10/28/16, 18:18

    UserToolbarItemDropDown.html:12

    our editorconfig file is changing this. tab with a size of 2 is defined in there...
  14. TYPO3com voted on patch set 4 V +1 10/28/16, 18:21 Completed build in 05m 00s on Fri, 28 Oct, 08:21 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4382

  15. Nicole Hummel commented on patch set 4 CR -1 10/28/16, 20:14

    UserToolbarItemDropDown.html:12 Reply

    To be honest I don't get the mix of tabs and whitespaces now. What is the right to use here?
  16. Wouter Wolters uploaded patch set 5 11/10/16, 19:28

  17. Wouter Wolters uploaded patch set 6 11/10/16, 19:29

  18. Wouter Wolters voted on patch set 6 CR +1 V +1 11/10/16, 19:29

  19. Nicole Hummel voted on patch set 6 CR +1 V +1 11/10/16, 19:32

  20. TYPO3com voted on patch set 5 V +1 11/10/16, 19:34 Completed build in 05m 29s on Thu, 10 Nov, 08:34 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4786

  21. TYPO3com voted on patch set 6 V +1 11/10/16, 19:37 Completed build in 08m 08s on Thu, 10 Nov, 08:37 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4787

  22. Jörg Bösche voted on patch set 6 CR +1 V +1 11/12/16, 23:49

  23. Christian Kuhn voted on patch set 6 CR +2 V +2 11/18/16, 22:21

  24. Gerrit merged patch set 6 11/18/16, 22:21