Review TYPO3_7-6 Merged

50431[BUGFIX] Allow "0" as path segment in ArrayUtility

Christian Kuhn CR +2 V +2 Normal +103 −10 updated 10/29/16, 11:14

Commit message

The empty() checks are too loose when checking for path segments
of an array, as "0" is a valid segment.
Instead we need to check for an empty string in the according places.

Also add a missing string check in getValueByPath.

Review

  • Code review CR +2
    • Nicole Hummel +2
    • Christian Kuhn +1
  • Verified V +2
    • Nicole Hummel +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 57

  1. Christian Kuhn commented on patch set 1 10/29/16, 09:40

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 10/29/16, 09:47 Completed build in 06m 46s on Sat, 29 Oct, 11:47 AM Test Summary: 10 of 20540 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-277

  3. Helmut Hummel uploaded patch set 2 10/29/16, 11:02

  4. TYPO3com voted on patch set 2 V +1 10/29/16, 11:07 Completed build in 05m 28s on Sat, 29 Oct, 01:07 PM Test Summary: 38030 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-279

  5. Christian Kuhn voted on patch set 2 CR +1 V +1 10/29/16, 11:12

  6. Nicole Hummel voted on patch set 2 CR +2 V +2 10/29/16, 11:14

  7. Gerrit merged patch set 2 10/29/16, 11:14