50506[TASK] Close document by clicking "Save and create new one"
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Jörg Bösche +1
- Michael Oehlhof +1
-
Verified V +2
- Markus Klein +2
- Michael Oehlhof +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1923
-
Markus Hölzle uploaded patch set 1 11/05/16, 11:33
-
TYPO3com voted on patch set 1 V +1 11/05/16, 11:38 Completed build in 04m 23s on Sat, 5 Nov, 12:38 PM Test Summary: 54839 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4606
-
Anja Leichsenring voted on patch set 1 CR +1 V +1 11/05/16, 14:37
-
Anja Leichsenring updated the commit message in patch set 2 11/05/16, 14:38
-
Anja Leichsenring voted on patch set 2 CR +1 V +1 11/05/16, 14:38
-
Markus Klein commented on patch set 2 11/05/16, 14:44
Bug in 7.6 as well? -
TYPO3com voted on patch set 2 V +1 11/05/16, 14:47 Completed build in 08m 20s on Sat, 5 Nov, 03:47 PM Test Summary: 54839 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4616
-
Frank Nägler commented on patch set 2 CR -1 11/07/16, 10:33
on it -
Frank Nägler uploaded patch set 3 11/07/16, 10:57
-
Frank Nägler commented on patch set 3 11/07/16, 10:59
I have added constants to optimize the readability. The method should be refactored, and implemented in a new way. but imho not within in this patch. -
TYPO3com voted on patch set 3 V +1 11/07/16, 11:02 Completed build in 04m 48s on Mon, 7 Nov, 12:02 PM Test Summary: 54863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4659
-
Markus Hölzle commented on patch set 3 CR +1 11/07/16, 12:17
Looks good for the moment, but I think we should fix it also for 7.6 (see forge) -
Frank Nägler updated the commit message in patch set 4 11/07/16, 13:33
-
TYPO3com voted on patch set 4 V +1 11/07/16, 13:37 Completed build in 04m 13s on Mon, 7 Nov, 02:37 PM Test Summary: 54863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4670
-
Markus Klein commented on patch set 4 11/07/16, 16:35
EditDocumentController.php:480isn't that already an int here?EditDocumentController.php:702same here -
Frank Nägler commented on patch set 4 11/08/16, 13:50
EditDocumentController.php:480ReplycloseDoc is a public property :/ we can't guarantee that it is alway an int -
Frank Nägler commented on patch set 4 11/08/16, 13:51
@Markus: as mentioned in the other comment, this part needs a refactoring, but not within this patch. -
Markus Klein commented on patch set 4 CR +1 11/08/16, 14:20
good then, thanks, overlooked that public thingy -
Michael Oehlhof voted on patch set 4 CR +1 V +1 11/09/16, 09:23
-
Jörg Bösche voted on patch set 4 CR +1 11/09/16, 18:32
-
Markus Klein voted on patch set 4 CR +2 V +2 11/12/16, 17:22
-
Gerrit merged patch set 4 11/12/16, 17:22
-
Markus Klein commented on patch set 5 11/12/16, 17:22
Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit a8343e8cd47cc2c142ea7c1f72016f061df8813b