Review main Merged

50607[TASK] Remove iconv support and use mbstring-polyfill

Markus Klein CR +2 V +2 Hard +425 −516 updated 12/05/16, 21:52

Commit message

We remove the iconv support in the CharsetConverter as the PHP internal
implementation of some functions differ from their mb_string pendants.
This gives us a real headache in edge-cases.

We already have the mbstring-polyfill as an indirect dependency in
the Core (by symfony), so we simply require it our own now and use
mb_string all over the places.

This renders quite a few methods of CharsetConverter useless
and we therefore deprecate those.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 22