Review main Merged

50694[TASK] Clarify code comments in GeneralUtility::getUserObj()

Benni Mack CR +2 V +2 Easy +5 −7 updated 11/17/16, 13:11

Commit message

The method GeneralUtility::getUserObj() already shows
that it will be exactly the same as makeInstance(), thus it will
be deprecated in TYPO3 v9.0, so the comments can be changed
accordingly already.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Wouter Wolters +1
  • Verified V +2
    • Stefan Neufeind +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Benni Mack uploaded patch set 1 11/17/16, 11:07

  2. TYPO3com voted on patch set 1 V +1 11/17/16, 11:11 Completed build in 03m 57s on Thu, 17 Nov, 12:11 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4957

  3. Wouter Wolters voted on patch set 1 CR +1 V +1 11/17/16, 11:53

  4. Stefan Neufeind voted on patch set 1 CR +2 V +2 11/17/16, 13:11

  5. Gerrit merged patch set 1 11/17/16, 13:11