Review TYPO3_7-6 Abandoned

50714[TASK] Compile ViewHelpers w/o CompilableInterface

Claus Due CR 0 V 0 Easy +7 −4 updated 04/12/17, 00:47

Commit message

This patch changes the behavior of the template parser
and template compiler ever so slightly, from not only
checking whether CompilableInterface is implemented,
to also checking if a compile() method exists.

It is done in order to allow third-party ViewHelpers to
be compilable without implementing the CompilableInterface.
And this is a good thing since CompilableInterface is
removed (alias remains) on TYPO3v8 - after this change,
such ViewHelpers will no longer be required to implement
an interface that is deprecated on one TYPO3 branch.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2