Review main Merged

50770[TASK] addCssInlineBlock function called with too many arguments

Wouter Wolters CR +2 V +2 Easy +4 −6 updated 11/26/16, 11:18

Commit message

addCssInlineBlock is called with 5 parameters instead of 4
in PageGenerator. We can safely remove the 5th argument.

Fixed two typos too.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Michael Oehlhof +1
  • Verified V +2
    • Andreas Kienast +2
    • Michael Oehlhof +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Wouter Wolters uploaded patch set 1 11/24/16, 22:38

  2. TYPO3com voted on patch set 1 V +1 11/24/16, 22:42 Completed build in 03m 26s on Thu, 24 Nov, 11:42 PM Test Summary: 55589 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5115

  3. Michael Oehlhof voted on patch set 1 CR +1 V +1 11/25/16, 17:06

  4. Andreas Kienast voted on patch set 1 CR +2 V +2 11/26/16, 11:17

  5. Gerrit merged patch set 1 11/26/16, 11:18