Review main Merged

50784[BUGFIX] Avoid building SQL deleteClause expression if unused

Claus Due CR +2 V +2 Easy +7 −9 updated 11/26/16, 19:30

Commit message

This patch avoids building an instance of ConnectionPool,
getting a QueryBuilder and building an expression unless
that expression is needed by the function.

Also switches a condition with else clause to an early
return guard clause (cosmetic only).

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1