Review main Merged

50791[BUGFIX] Re-apply colorspace to resulting image

Stefan Neufeind CR +2 V +2 Easy +2 −0 updated 02/04/18, 18:42

Commit message

When using filters the colorspace is not always applied.
A quickfix is to add the colorspace-setting again before
writing the output-image.
Multiple colorspace-settings on the commandline will be
executed in order. For example the grayscale-filter uses
"-colorspace GRAY". The final output-image can then be
converted to "-colorspace sRGB" again so the brightness
appears correct (not too dark) again.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
  • Verified V +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1114

  1. Stefan Neufeind uploaded patch set 1 11/28/16, 10:36

  2. TYPO3com voted on patch set 1 V +1 11/28/16, 10:40 Completed build in 04m 08s on Mon, 28 Nov, 11:40 AM Test Summary: 55589 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5165

  3. Susi Moog commented on patch set 1 12/09/17, 19:49

    ping are you still working on this?
  4. Stefan Neufeind updated the commit message in patch set 2 12/11/17, 06:23

  5. Stefan Neufeind commented on patch set 2 12/11/17, 06:24

    Haven't given this a try since a while and don't have a test-setup at hand right-away. But if I remember correctly that change worked out. Let's see/discuss if the approach is right. I've thus removed the WIP-status.
  6. TYPO3com voted on patch set 2 V +1 12/11/17, 06:34 Completed build in 10m 22s on Mon, 11 Dec, 07:34 AM Test Summary: 57075 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17543

  7. Mathias Schreiber voted on patch set 2 V +1 CR +1 02/04/18, 15:03

  8. Christian Kuhn updated the commit message in patch set 3 02/04/18, 18:33

  9. Mathias Schreiber voted on patch set 3 V +1 CR +1 02/04/18, 18:33

  10. Christian Kuhn commented on patch set 3 V +1 CR +1 02/04/18, 18:34

    mathias explained details to me - looks good, let's get it done. removed v7 though, imho not critical.
  11. TYPO3com voted on patch set 3 V +1 02/04/18, 18:40 Completed build in 07m 28s on Sun, 4 Feb, 07:40 PM Test Summary: 30390 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18905

  12. Christian Kuhn voted on patch set 3 V +2 CR +2 02/04/18, 18:42

  13. Christian Kuhn merged patch set 4 02/04/18, 18:42

  14. Christian Kuhn commented on patch set 4 02/04/18, 18:42

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 7eeed0a01be656316fbc73bd8af5da65239ed0ce