Review main Merged

50799[TASK] Move FE user intialization into constructor

Benni Mack CR +2 V +2 Easy +3 −3 updated 11/29/16, 20:16

Commit message

Certain options are set from outside as public property,
however these options are always set and can be set from within
FrontendUserAuthentication itself.

This way, more "logic" is moved from TSFE into the appropriate
objects themselves.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Georg Ringer +1
    • Andreas Kienast +1
    • Mathias Brodala +1
  • Verified V +2
    • Wouter Wolters +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 78

  1. Benni Mack uploaded patch set 1 11/29/16, 09:33

  2. Mathias Brodala voted on patch set 1 CR +1 11/29/16, 09:34

  3. Andreas Kienast voted on patch set 1 CR +1 11/29/16, 09:35

  4. TYPO3com voted on patch set 1 V +1 11/29/16, 09:36 Completed build in 03m 27s on Tue, 29 Nov, 10:36 AM Test Summary: 54077 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5186

  5. Georg Ringer voted on patch set 1 CR +1 V +1 11/29/16, 12:12

  6. Wouter Wolters voted on patch set 1 CR +1 11/29/16, 13:39

  7. Wouter Wolters voted on patch set 1 CR +2 V +2 11/29/16, 20:16

  8. Gerrit merged patch set 1 11/29/16, 20:16