Review main Merged

50910[BUGFIX] Fix exception in QuickEdit mode for empty pages

Manuel Selbach CR +2 V +2 Easy +25 −17 updated 12/13/16, 04:21

Commit message

If there is no content on a page the parameter $this->eRParts[1] will be
set to e.g. /new/1 which is not an integer value and it will throw an
exception here on certain dbms, thus let's check that before as there could
not be a history on a new record and skip the query to prevent the error.

Review

  • Code review CR +2
    • Markus Klein +2
    • Wouter Wolters +1
    • Alexander Stehlik +1
    • Tymoteusz Motylewski +1
    • Michael Oehlhof +1
  • Verified V +2
    • Markus Klein +2
    • Tymoteusz Motylewski +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1012

  1. Manuel Selbach uploaded patch set 1 12/08/16, 22:26

  2. TYPO3com voted on patch set 1 V +1 12/08/16, 22:31 Completed build in 04m 17s on Thu, 8 Dec, 11:31 PM Test Summary: 54373 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5622

  3. Markus Klein commented on patch set 1 12/08/16, 22:34

    PageLayoutController.php:922

    cannot
  4. Markus Klein commented on patch set 2 12/08/16, 22:35

    Published edit on patch set 1.
  5. Markus Klein voted on patch set 2 CR +1 12/08/16, 22:35

  6. TYPO3com voted on patch set 2 V +1 12/08/16, 22:40 Completed build in 04m 58s on Thu, 8 Dec, 11:40 PM Test Summary: 54373 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5623

  7. Wouter Wolters voted on patch set 2 CR +1 12/09/16, 20:26

  8. Alexander Stehlik voted on patch set 2 CR +1 12/10/16, 11:58

  9. Tymoteusz Motylewski voted on patch set 2 CR +1 V +1 12/10/16, 12:02

  10. Michael Oehlhof voted on patch set 2 CR +1 12/12/16, 20:24

  11. Markus Klein voted on patch set 2 CR +2 V +2 12/13/16, 04:21

  12. Gerrit merged patch set 2 12/13/16, 04:21