Review main Abandoned

50986[BUGFIX] handle null values in translations

Marco Huber CR 0 V 0 Easy +1 −1 updated 02/04/18, 15:12

Commit message

NULL can be a valid value, so this check shouldn't fail
if the value is NULL.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 912

  1. Marco Huber uploaded patch set 1 12/16/16, 10:31

  2. TYPO3com voted on patch set 1 V +1 12/16/16, 10:36 Completed build in 04m 38s on Fri, 16 Dec, 11:36 AM Test Summary: 54391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5808

  3. Marco Huber rebased onto patch set 2 12/16/16, 10:43

  4. TYPO3com voted on patch set 2 V +1 12/16/16, 10:47 Completed build in 03m 11s on Fri, 16 Dec, 11:47 AM Test Summary: 54391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5809

  5. Marco Huber uploaded patch set 3 02/14/17, 12:09

  6. Marco Huber commented on patch set 3 02/14/17, 12:10

    Patch Set 2 was rebased.
  7. TYPO3com voted on patch set 3 V +1 02/14/17, 12:14 Completed build in 05m 14s on Tue, 14 Feb, 01:14 PM Test Summary: 56275 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8038

  8. Tymoteusz Motylewski commented on patch set 3 02/15/17, 19:05

    Hi Are you able to provide a test covering the case?
  9. Marco Huber commented on patch set 3 02/15/17, 19:34

    Hi, the EXT:news is a good example to test this behavior: http://stackoverflow.com/questions/41181974/typo3-default-language-content-shown Or do you mean unit tests? Sorry, I'm not good in writing unit tests and have no idea how or where to test this. Perhaps you can give me an example test?
  10. Sascha Egerer commented on patch set 3 CR -1 02/19/17, 21:25

    PageRepository.php:594

    With this change the value is always overridden isnt it? The key does always exist as the column exists.
  11. Christian Kuhn commented on patch set 3 02/04/18, 15:12

    hey. i think we should abandon this patch: the noCopy TCA mode has been removed in v8 and overlays are now always full records without the fallback handling to default language. thus, the issue should be no longer relevant.
  12. Christian Kuhn abandoned the change 02/04/18, 15:12