50987[BUGFIX] Delete relations of tables without delete-field
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 86
- typo3/sysext/core/Classes/DataHandling/DataHandler.php7+17 −5
- typo3/sysext/core/Classes/DataHandling/PlainDataResolver.php+4 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/CategoryManyToMany/Modify/DataSet/deleteContentOfRelationWithoutSoftDelete.csvnew+23 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/CategoryManyToMany/Modify/ActionTest.php+7 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/CategoryManyToMany/WorkspacesDiscard/ActionTest.php+8 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/CategoryManyToMany/WorkspacesModify/DataSet/deleteContentOfRelationWithoutSoftDelete.csvnew+36 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/CategoryManyToMany/WorkspacesModify/ActionTest.php+7 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/CategoryManyToMany/WorkspacesPublish/DataSet/deleteContentOfRelationWithoutSoftDelete.csvnew+32 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/CategoryManyToMany/WorkspacesPublish/ActionTest.php+8 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/CategoryManyToMany/WorkspacesPublishAll/DataSet/deleteContentOfRelationWithoutSoftDelete.csvnew+32 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/CategoryManyToMany/WorkspacesPublishAll/ActionTest.php+8 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/CategoryManyToMany/AbstractActionTestCase.php+9 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Flex/Modify/DataSet/deleteRecordThenHardDeleteRecord.csvnew+116 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Flex/Modify/DataSet/deleteRecordWithoutSoftDelete.csvnew+102 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Flex/Modify/ActionTest.php+15 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Flex/WorkspacesDiscard/DataSet/deleteRecordWithoutSoftDelete.csvnew+160 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Flex/WorkspacesDiscard/ActionTest.php+8 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Flex/WorkspacesModify/DataSet/deleteRecordWithoutSoftDelete.csvnew+223 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Flex/WorkspacesModify/ActionTest.php+7 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Flex/WorkspacesPublish/DataSet/deleteRecordWithoutSoftDelete.csvnew+111 −0
Show 66 more files
- typo3/sysext/core/Tests/Functional/DataScenarios/Flex/WorkspacesPublish/ActionTest.php+8 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Flex/WorkspacesPublishAll/DataSet/deleteRecordWithoutSoftDelete.csvnew+111 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Flex/WorkspacesPublishAll/ActionTest.php+8 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Flex/AbstractActionTestCase.php+22 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Group/Modify/DataSet/deleteContentOfRelationWithoutSoftDelete.csvnew+18 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Group/Modify/ActionTest.php+7 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Group/WorkspacesDiscard/DataSet/deleteContentOfRelationWithoutSoftDelete.csvnew+30 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Group/WorkspacesDiscard/ActionTest.php+8 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Group/WorkspacesModify/DataSet/deleteContentOfRelationWithoutSoftDelete.csvnew+33 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Group/WorkspacesModify/ActionTest.php+7 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Group/WorkspacesPublish/DataSet/deleteContentOfRelationWithoutSoftDelete.csvnew+27 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Group/WorkspacesPublish/ActionTest.php+8 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Group/WorkspacesPublishAll/DataSet/deleteContentOfRelationWithoutSoftDelete.csvnew+27 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Group/WorkspacesPublishAll/ActionTest.php+8 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Group/AbstractActionTestCase.php+9 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreCsv/Modify/DataSet/deleteParentContentThenHardDeleteParentContent.csvnew+41 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreCsv/Modify/DataSet/deleteParentContentWithoutSoftDelete.csvnew+41 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreCsv/Modify/ActionTest.php+14 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreCsv/WorkspacesDiscard/DataSet/deleteParentContentWithoutSoftDelete.csvnew+55 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreCsv/WorkspacesDiscard/ActionTest.php+8 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreCsv/WorkspacesModify/DataSet/deleteParentContentWithoutSoftDelete.csvnew+62 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreCsv/WorkspacesModify/ActionTest.php+7 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreCsv/WorkspacesPublish/DataSet/deleteParentContentWithoutSoftDelete.csvnew+48 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreCsv/WorkspacesPublish/ActionTest.php+8 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreCsv/WorkspacesPublishAll/DataSet/deleteParentContentWithoutSoftDelete.csvnew+48 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreCsv/WorkspacesPublishAll/ActionTest.php+8 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreCsv/AbstractActionTestCase.php+21 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/Modify/DataSet/deleteParentContentThenHardDeleteParentContent.csvnew+41 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/Modify/DataSet/deleteParentContentWithoutSoftDelete.csvnew+41 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/Modify/ActionTest.php+14 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/WorkspacesDiscard/DataSet/deleteParentContentWithoutSoftDelete.csvnew+57 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/WorkspacesDiscard/ActionTest.php+8 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/WorkspacesModify/DataSet/deleteParentContentWithoutSoftDelete.csvnew+64 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/WorkspacesModify/ActionTest.php+7 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/WorkspacesPublish/DataSet/deleteParentContentWithoutSoftDelete.csvnew+50 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/WorkspacesPublish/ActionTest.php+8 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/WorkspacesPublishAll/DataSet/deleteParentContentWithoutSoftDelete.csvnew+50 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/WorkspacesPublishAll/ActionTest.php+8 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/AbstractActionTestCase.php+21 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/deleteParentContentWithoutSoftDelete.csvnew+41 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/ActionTest.php+7 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/WorkspacesModify/DataSet/deleteParentContentWithoutSoftDelete.csvnew+59 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/WorkspacesModify/ActionTest.php+7 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/AbstractActionTestCase.php+7 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/Modify/DataSet/deleteContentOfRelationWithoutSoftDelete.csvnew+24 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/Modify/ActionTest.php+7 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/WorkspacesDiscard/DataSet/deleteContentOfRelationWithoutSoftDelete.csvnew+38 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/WorkspacesDiscard/ActionTest.php+8 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/WorkspacesModify/DataSet/deleteContentOfRelationWithoutSoftDelete.csvnew+44 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/WorkspacesModify/ActionTest.php+7 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/WorkspacesPublish/DataSet/deleteContentOfRelationWithoutSoftDelete.csvnew+33 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/WorkspacesPublish/ActionTest.php+8 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/WorkspacesPublishAll/DataSet/deleteContentOfRelationWithoutSoftDelete.csvnew+33 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/WorkspacesPublishAll/ActionTest.php+8 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/AbstractActionTestCase.php+9 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Select/Modify/DataSet/deleteContentOfRelationWithoutSoftDelete.csvnew+18 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Select/Modify/ActionTest.php+7 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Select/WorkspacesDiscard/DataSet/deleteContentOfRelationWithoutSoftDelete.csvnew+30 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Select/WorkspacesDiscard/ActionTest.php+8 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Select/WorkspacesModify/DataSet/deleteContentOfRelationWithoutSoftDelete.csvnew+26 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Select/WorkspacesModify/ActionTest.php+7 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Select/WorkspacesPublish/DataSet/deleteContentOfRelationWithoutSoftDelete.csvnew+20 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Select/WorkspacesPublish/ActionTest.php+8 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Select/WorkspacesPublishAll/DataSet/deleteContentOfRelationWithoutSoftDelete.csvnew+20 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Select/WorkspacesPublishAll/ActionTest.php+8 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Select/AbstractActionTestCase.php+9 −0
Review log 76102
Show 6177 earlier messages
-
Stephan Großberndt uploaded patch set 1 12/16/16, 11:25
-
TYPO3com voted on patch set 1 V -1 12/16/16, 11:29 Completed build in 03m 55s on Fri, 16 Dec, 12:29 PM Test Summary: 116 of 54391 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5810
-
Stephan Großberndt uploaded patch set 2 12/16/16, 11:52
-
TYPO3com voted on patch set 2 V +1 12/16/16, 11:58 Completed build in 05m 45s on Fri, 16 Dec, 12:58 PM Test Summary: 54391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5816
-
Stephan Großberndt voted on patch set 2 V -1 12/16/16, 13:02
-
Stephan Großberndt commented on patch set 2 12/16/16, 14:10
Does not delete mm relations yet. -
Benni Mack commented on patch set 2 09/09/17, 23:20
What to do here? -
Stephan Großberndt commented on patch set 2 09/11/17, 15:30
First of all: decide what has to happen to MM-records between tables if one side is deleted. Keep the MM records so if undeleting the relations are still there? -
Mathias Schreiber commented on patch set 2 03/01/18, 21:08
can you provide a bit of TCA here or at least define the cases? -
Stephan Großberndt commented on patch set 2 03/02/18, 10:21
-
Benni Mack commented on patch set 2 10/01/18, 18:04
Decision: We keep them :) -
Benni Mack abandoned the change 10/27/18, 15:15
Stephan, I'll abandon this one for now. Hope that's ok. If not, let me know. -
Stephan Großberndt restored the change 10/27/18, 15:23
-
Stephan Großberndt wrote 10/27/18, 15:24
Removed Verified-1 by Stephan Großberndt <stephan.grossberndt@typo3.org> -
Stephan Großberndt updated the commit message in patch set 3 10/27/18, 15:25
-
TYPO3com voted on patch set 3 V -1 10/27/18, 15:25 Completed build in 07s on Sat, 27 Oct, 05:25 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29680
-
Stephan Großberndt uploaded patch set 4 02/18/19, 09:09
-
TYPO3com voted on patch set 4 V -1 02/18/19, 09:09 Completed build in 15s on Mon, 18 Feb, 10:09 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32274
-
Stephan Großberndt marked it work in progress 02/18/19, 09:09
-
Stephan Großberndt uploaded patch set 5 02/18/19, 09:10
-
Stephan Großberndt marked it work in progress 02/18/19, 09:12
-
TYPO3com voted on patch set 5 V +1 02/18/19, 09:26 Completed build in 13m 50s on Mon, 18 Feb, 10:26 AM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32276
-
Oliver Klee updated the commit message in patch set 6 02/18/19, 11:21
-
TYPO3com voted on patch set 6 V +1 02/18/19, 11:34 Completed build in 12m 22s on Mon, 18 Feb, 12:33 PM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32278
-
Stephan Großberndt updated the commit message in patch set 7 02/18/19, 11:51
-
Stephan Großberndt commented on patch set 7 02/18/19, 11:52
Definitely not for 8.7 (important and security bugfixes only) -
TYPO3com voted on patch set 7 V +1 02/18/19, 12:03 Completed build in 11m 37s on Mon, 18 Feb, 01:03 PM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32279
-
Stephan Großberndt updated the commit message in patch set 8 03/17/19, 17:53
-
Stephan Großberndt wrote 03/17/19, 17:54
Description "Edit commit message" removed -
Stephan Großberndt wrote 03/17/19, 17:54
Description set to "Edit commit message" -
TYPO3com voted on patch set 8 V +1 03/17/19, 18:03 Completed build in 09m 54s on Sun, 17 Mar, 07:03 PM Test Summary: 47201 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32827
-
Markus Klein voted on patch set 8 V +1 CR +1 08/01/19, 07:43
-
Tymoteusz Motylewski commented on patch set 8 08/02/19, 05:21
Can we please have some functional tests for this case? -
Tymoteusz Motylewski commented on patch set 8 08/02/19, 05:21
This change is ready for review. -
Richard Haeser voted on patch set 8 CR +1 09/07/19, 07:06
-
Oliver Klee commented on patch set 8 09/07/19, 08:59
DataHandler.php:4695If I read the code correctly, $deleteField will be either 0 or 1. So this line should be this instead, I suppose: if ($deleteField === 0) { -
Stephan Großberndt commented on patch set 8 09/09/19, 08:58
DataHandler.php:4695ReplyNo, `$GLOBALS['TCA'][$table]['ctrl']['delete']` this is no a value of 0/1 but a string containing the column name which defines as the column storing the delete-status: https://docs.typo3.org/m/typo3/reference-tca/master/en-us/Ctrl/Index.html#delete -
Oliver Klee commented on patch set 8 09/09/19, 11:07
DataHandler.php:4695ReplyAh, I see. Then the comparison should be !== ''. -
Stephan Großberndt commented on patch set 8 09/09/19, 15:00
DataHandler.php:4695ReplyNo. This is about the case if there is NO delete column defined, so I guess you meant ($deleteField === '') - but this would be wrong too. Usually in TCA the ['ctrl']['delete'] subarray does not even exist if no delete column is defined. So even if I would add a strict comparison to NULL to catch that what about (unlikely but possible) $GLOBALS['TCA'][$table]['ctrl']['delete'] = ''; $GLOBALS['TCA'][$table]['ctrl']['delete'] = NULL; or $GLOBALS['TCA'][$table]['ctrl']['delete'] = 0; Simply negating the value catches all those cases without explicitly specifing all variants. -
Sascha Rademacher voted on patch set 8 CR +1 10/10/19, 11:47
-
Susi Moog voted on patch set 8 CR +1 11/09/19, 15:49
-
Benni Mack uploaded patch set 9 11/09/19, 16:20
-
Benni Mack commented on patch set 9 V +1 CR -2 11/09/19, 16:21
Added tests. Works as expected! Thanks! I'd like to have Olly Hader look over the tests though, blocked until then. -
TYPO3com voted on patch set 9 V -1 11/09/19, 16:30 Completed build in 09m 27s on Sat, 9 Nov, 04:30 PM Test Summary: 3 of 48645 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38203
-
Benni Mack uploaded patch set 10 11/09/19, 17:32
-
TYPO3com voted on patch set 10 V +1 11/09/19, 17:42 Completed build in 10m 24s on Sat, 9 Nov, 05:42 PM Test Summary: 48299 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38215
-
Ursula Klinger commented on patch set 10 11/11/19, 18:29
DataHandler.php:4734Why do you check deletedField? when a hard delete is made in the elseif case, I would also call deleteRecord_procFields to delete the related records. -
Stephan Großberndt commented on patch set 10 11/12/19, 10:31
DataHandler.php:4734ReplyThis patch was meant to only change the behaviour for tables which do NOT have a $deleteField defined. $deleteField contains the value of `$GLOBALS['TCA'][$table]['ctrl']['delete']` which is a string containing the column name which defines as the column storing the delete-status: https://docs.typo3.org/m/typo3/reference-tca/master/en-us/Ctrl/Index.html#delete Hard deleting of records in tables which have a defined $deleteField is not done at all in DataHandler. If there is a $deleteField defined for a table, records are always set to value `1` in the $deleteField and may be hard deleted in recycler or via cronjobs. -
Oliver Hader commented on patch set 10 11/19/19, 10:55
Nice, thanks for providing test-cases here. The `undelete` case is currently not covered with tests at all - which should be done before we can continue with this change here... -
Benni Mack wrote 04/06/20, 09:44
Topic set to DataHandler -
Benni Mack updated the commit message in patch set 11 05/25/20, 18:46
-
TYPO3com voted on patch set 11 V +1 08/11/20, 08:46 Completed build in 11m 38s on Tue, 11 Aug, 08:46 AM Test Summary: 72998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4564
-
Stephan Großberndt rebased onto patch set 12 11/23/20, 12:03
-
TYPO3com voted on patch set 12 V -1 11/23/20, 14:09 Completed build in 13m 14s on Mon, 23 Nov, 02:09 PM Test Summary: 9 of 32641 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7515
-
Benni Mack updated the commit message in patch set 13 11/18/21, 10:37
-
Benni Mack wrote 11/29/21, 10:17
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 14 11/29/21, 14:08
-
Oliver Klee wrote 11/29/21, 14:19
Removed cc Oliver Klee. -
Christian Kuhn commented on patch set 14 02/04/23, 10:49
is this still an issue? we had a series of changes in DH delete handling in v11, so this may be fixed already? -
Markus Klein commented on patch set 14 02/05/23, 00:15
Reply
Will check -
Markus Klein commented on patch set 14 02/06/23, 19:42
Reply
Bug still existing! -
Benni Mack updated the commit message in patch set 15 05/03/23, 09:30
Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN") -
Markus Klein commented on patch set 15 CR +1 09/12/24, 06:51
DataHandler.php:4734ReplyDone -
Benni Mack updated the commit message in patch set 16
CR +110/18/24, 13:49Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Christian Kuhn commented on patch set 16 02/05/25, 19:27
up. i stumbled upon the same question when reading DH delete code. i'm currently refactoring DH delete and will hopefully pick this up soon. -
Benni Mack uploaded patch set 17 04/16/25, 14:17
Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Benni Mack voted on patch set 17 CR 0 04/16/25, 14:19
-
core-ci voted on patch set 17 V -1 04/16/25, 14:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77842
-
Benni Mack uploaded patch set 18
V -104/16/25, 14:34 -
core-ci voted on patch set 18 V +1 04/16/25, 14:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77844
-
Benni Mack commented on patch set 18 04/16/25, 14:46
I have a feeling this change is not complete, (I have a few todos, because relations are not removed properly), but at least we have all tests and an updated MR -
Christian Kuhn commented on patch set 18 05/22/25, 15:01
i'm looking at a related scenario: forceDelete = true with https://review.typo3.org/c/Packages/TYPO3.CMS/+/89497. i think we should pick this change up when the other one is done. -
Christian Kuhn uploaded patch set 19
V +105/27/25, 16:27 -
core-ci voted on patch set 19 V -1 05/27/25, 16:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79584
-
Christian Kuhn commented on patch set 19 05/28/25, 08:19
Reply
Done -
Christian Kuhn uploaded patch set 20
V -105/28/25, 09:15 -
core-ci voted on patch set 20 V -1 05/28/25, 09:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79618
-
Christian Kuhn uploaded patch set 21
V -105/28/25, 09:57 -
core-ci voted on patch set 21 V -1 05/28/25, 10:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79627
-
Christian Kuhn uploaded patch set 22
V -105/28/25, 10:14 -
core-ci voted on patch set 22 V -1 05/28/25, 10:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79630
-
Christian Kuhn uploaded patch set 23
V -105/28/25, 10:36 -
Christian Kuhn uploaded patch set 24 05/28/25, 10:39
-
Christian Kuhn uploaded patch set 25 05/28/25, 10:45
-
core-ci voted on patch set 23 V -1 05/28/25, 10:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79632
-
Christian Kuhn uploaded patch set 26 05/28/25, 10:49
-
core-ci voted on patch set 24 V -1 05/28/25, 10:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79633
-
core-ci voted on patch set 25 V +1 05/28/25, 10:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79634
-
core-ci voted on patch set 26 V +1 05/28/25, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79635
-
Christian Kuhn uploaded patch set 27
V +105/28/25, 12:04 -
core-ci voted on patch set 27 V +1 05/28/25, 12:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79639
-
Christian Kuhn uploaded patch set 28
V +105/28/25, 13:59 -
core-ci voted on patch set 28 V -1 05/28/25, 14:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79645
-
Christian Kuhn uploaded patch set 29
V -105/28/25, 15:27 -
Christian Kuhn updated the commit message in patch set 30 05/28/25, 15:33
-
Christian Kuhn voted on patch set 30 CR +1 V +1 05/28/25, 15:33
-
core-ci voted on patch set 29 V +1 05/28/25, 15:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79650
-
core-ci voted on patch set 30 V +1 05/28/25, 15:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79652
-
Benni Mack voted on patch set 30 CR +1 V +1 05/28/25, 15:58
-
Stefan Bürk voted on patch set 30 CR +1 V +1 05/28/25, 16:20
-
Christian Kuhn voted on patch set 30 CR +2 V +2 05/28/25, 16:51
-
Christian Kuhn merged patch set 31 05/28/25, 16:52