51021[BUGFIX] Fix getTemplatePathAndFilename on StandaloneView
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Markus Sommer +1
-
Verified V +2
- Christian Kuhn +2
- Markus Sommer +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1723
-
Claus Due uploaded patch set 1 12/22/16, 12:29
-
Claus Due commented on patch set 1 12/22/16, 12:30
Please do not review until https://review.typo3.org/#/c/51020/ is merged and this is rebased / conflict resolved! -
TYPO3com voted on patch set 1 V +1 12/22/16, 12:34 Completed build in 04m 40s on Thu, 22 Dec, 01:34 PM Test Summary: 54399 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5927
-
Markus Klein commented on patch set 1 CR -1 12/22/16, 16:01
Please base this code onto the currently clean code, without reverting our changes. Thanks a lot! -
Markus Klein commented on patch set 1 12/22/16, 16:03
StandaloneView.php:49if you remove that above, we have dynamic declaration hereStandaloneView.php:72call parent constructor whenever possible!StandaloneView.php:87unsafe typing again! -
Claus Due commented on patch set 1 12/22/16, 16:27
Don't review this one until it is rebased after reverting the original (that will make the diff a lot smaller, too) -
Claus Due uploaded patch set 2 05/11/17, 12:09
-
Claus Due rebased onto patch set 3 05/11/17, 12:10
-
TYPO3com voted on patch set 2 V +1 05/11/17, 12:15 Completed build in 06m 10s on Thu, 11 May, 02:15 PM Test Summary: 55836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11383
-
TYPO3com voted on patch set 3 V +1 05/11/17, 12:19 Completed build in 09m 09s on Thu, 11 May, 02:19 PM Test Summary: 55836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11384
-
Claus Due uploaded patch set 4 05/11/17, 12:23
-
TYPO3com voted on patch set 4 V +1 05/11/17, 12:30 Completed build in 06m 42s on Thu, 11 May, 02:30 PM Test Summary: 55914 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11388
-
Claus Due rebased onto patch set 5 05/11/17, 12:56
-
TYPO3com voted on patch set 5 V +1 05/11/17, 13:02 Completed build in 06m 19s on Thu, 11 May, 03:02 PM Test Summary: 55914 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11394
-
Markus Klein commented on patch set 5 05/26/17, 16:38
8.7 too i guess -
Christian Kuhn updated the commit message in patch set 6 06/04/17, 09:44
-
TYPO3com voted on patch set 6 V +1 06/04/17, 09:54 Completed build in 10m 02s on Sun, 4 Jun, 11:54 AM Test Summary: 2334 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-12302
-
Christian Kuhn commented on patch set 6 CR -1 06/04/17, 10:02
temp -1, sorting out a detail. -
Christian Kuhn voted on patch set 6 CR +1 V +1 06/04/17, 10:15
-
Markus Sommer voted on patch set 6 CR +1 V +1 06/04/17, 10:16
-
Christian Kuhn voted on patch set 6 CR +2 V +2 06/04/17, 11:43
-
Gerrit merged patch set 6 06/04/17, 11:43
-
Christian Kuhn commented on patch set 7 06/04/17, 11:44
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 504f8e3d0f0a9b5f58268879e22c04320dec8032