Review main Merged

5104[BUGFIX] magic_quotes_gpc does not exist anymore in PHP 5.4

Xavier Perseguers CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

PHP INI magic_quotes_gpc got deprecated in PHP 5.3 and is removed in
PHP 5.4, init.php should then behave as if it were set to "Off".

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Georg Ringer +1
    • Ernesto Baschny +1
    • Karsten Dambekalns +1
  • Verified V +2
    • Xavier Perseguers +2

Files 1

Review log 12

  1. Xavier Perseguers commented on patch set 1 11/22/11, 10:04

    Do not submit Although this setting does not exist anymore in PHP 5.4 and the get_magic_quotes_gpc() method always currently returns 0 (="Off"), we should wait until the release of PHP 5.4 as their deprecation/removal policy is not clear and the official manual is not updated in this sense.
  2. Xavier Perseguers commented on patch set 1 11/22/11, 10:04

    Looks good to me, but someone else must approve According to ChangeLog, it got removed: http://www.php.net/releases/NEWS_5_4_0_beta1.txt
  3. Karsten Dambekalns commented on patch set 2 11/22/11, 10:04

    Looks good to me, but someone else must approve
  4. Ernesto Baschny commented on patch set 2 11/22/11, 10:04

    Looks good to me, but someone else must approve
  5. Xavier Perseguers commented on patch set 2 V 0 11/22/11, 10:04

    by team member; Looks good to me, approved
  6. Xavier Perseguers uploaded patch set 2 11/22/11, 10:04

  7. Xavier Perseguers commented on patch set 2 11/22/11, 10:04

    Verified; Looks good to me, but someone else must approve
  8. Christian Kuhn commented on patch set 1 11/22/11, 10:04

    +1 to wait for 4.6 final, but to handle it as soon as it was released. There are further settings like safe_mode and register_globals that are affected.
  9. Georg Ringer commented on patch set 2 11/22/11, 10:04

    Looks good to me, but someone else must approve
  10. Mr. Jenkins commented on patch set 1 11/22/11, 10:04

  11. Mr. Jenkins commented on patch set 2 11/22/11, 10:04

  12. Xavier Perseguers merged patch set 2 11/22/11, 10:04