5104[BUGFIX] magic_quotes_gpc does not exist anymore in PHP 5.4
Commit message
Review
-
Code review CR +2
- Xavier Perseguers +2
- Georg Ringer +1
- Ernesto Baschny +1
- Karsten Dambekalns +1
-
Verified V +2
- Xavier Perseguers +2
Files 1
Review log 12
-
Xavier Perseguers commented on patch set 1 11/22/11, 10:04
Do not submit Although this setting does not exist anymore in PHP 5.4 and the get_magic_quotes_gpc() method always currently returns 0 (="Off"), we should wait until the release of PHP 5.4 as their deprecation/removal policy is not clear and the official manual is not updated in this sense. -
Xavier Perseguers commented on patch set 1 11/22/11, 10:04
Looks good to me, but someone else must approve According to ChangeLog, it got removed: http://www.php.net/releases/NEWS_5_4_0_beta1.txt -
Karsten Dambekalns commented on patch set 2 11/22/11, 10:04
Looks good to me, but someone else must approve -
Ernesto Baschny commented on patch set 2 11/22/11, 10:04
Looks good to me, but someone else must approve -
Xavier Perseguers commented on patch set 2 V 0 11/22/11, 10:04
by team member; Looks good to me, approved -
Xavier Perseguers uploaded patch set 2 11/22/11, 10:04
-
Xavier Perseguers commented on patch set 2 11/22/11, 10:04
Verified; Looks good to me, but someone else must approve -
Christian Kuhn commented on patch set 1 11/22/11, 10:04
+1 to wait for 4.6 final, but to handle it as soon as it was released. There are further settings like safe_mode and register_globals that are affected. -
Georg Ringer commented on patch set 2 11/22/11, 10:04
Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 11/22/11, 10:04
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1931/ : SUCCESS -
Mr. Jenkins commented on patch set 2 11/22/11, 10:04
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2459/ : SUCCESS -
Xavier Perseguers merged patch set 2 11/22/11, 10:04