Review main Abandoned

51051[WIP][FEATURE] Minify HTML using wyrihaximus/html-compress

Georg Ringer CR 0 V 0 Hard +549 −277 updated 09/16/18, 22:20

Commit message

By setting config.minifyHtml = all, the generated HTML is minified.
Further configuration options are fullCached,nonCached,partlyCached to react on cache beahviour of current request.

Composer command used:
- composer req wyrihaximus/html-compress

Further changes
- Minify JS
- Minify CSS by using CssMin

Todos:
- issue
- rst
- compare with https://review.typo3.org/c/52864/

Review

  • Code review CR 0
  • Verified V 0

Files 12

Review log 1423

  1. Georg Ringer uploaded patch set 1 12/27/16, 19:06

  2. TYPO3com voted on patch set 1 V +1 12/27/16, 19:10 Completed build in 04m 18s on Tue, 27 Dec, 08:10 PM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5995

  3. Georg Ringer uploaded patch set 2 12/28/16, 13:23

  4. TYPO3com voted on patch set 2 V -1 12/28/16, 13:28 Completed build in 04m 30s on Wed, 28 Dec, 02:28 PM Test Summary: 48 of 54417 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6012

  5. Georg Ringer uploaded patch set 3 12/28/16, 13:37

  6. TYPO3com voted on patch set 3 V -1 12/28/16, 13:41 Completed build in 04m 41s on Wed, 28 Dec, 02:41 PM Test Summary: 48 of 54417 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6015

  7. Benni Mack commented on patch set 3 12/09/17, 02:20

    what to use? there is another lib out there as well. https://review.typo3.org/#/c/52864/
  8. Benni Mack uploaded patch set 4 02/10/18, 23:16

  9. Benni Mack commented on patch set 4 02/10/18, 23:17

    I think we should use this base and incorporate the changes from here: https://review.typo3.org/#/c/52864/
  10. TYPO3com voted on patch set 4 V -1 02/10/18, 23:24 Completed build in 08m 13s on Sun, 11 Feb, 12:24 AM Test Summary: 24 of 30637 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19326

  11. Georg Ringer commented on patch set 4 02/13/18, 22:19

    the other lib has far more downloads, so I would use that one. will take a look
  12. Benni Mack commented on patch set 4 02/13/18, 23:08

    well, yours does HTML compression. the other one doesn't. however, the wyrihaximus library looks like a summarization bundle of all the others.
  13. Georg Ringer uploaded patch set 5 02/14/18, 14:29

  14. TYPO3com voted on patch set 5 V -1 02/14/18, 14:29 Completed build in 08s on Wed, 14 Feb, 03:29 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19573

  15. Georg Ringer uploaded patch set 6 02/14/18, 15:19

  16. TYPO3com voted on patch set 6 V -1 02/14/18, 15:19 Completed build in 10s on Wed, 14 Feb, 04:19 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19577

  17. Georg Ringer uploaded patch set 7 02/14/18, 15:43

  18. TYPO3com voted on patch set 7 V -1 02/14/18, 15:52 Completed build in 08m 46s on Wed, 14 Feb, 04:52 PM Test Summary: 24 of 30929 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19580

  19. Georg Ringer uploaded patch set 8 03/01/18, 15:40

  20. TYPO3com voted on patch set 8 V -1 03/01/18, 15:51 Completed build in 11m 11s on Thu, 1 Mar, 04:51 PM Test Summary: 15 of 31008 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20373

  21. Georg Ringer uploaded patch set 9 03/01/18, 16:56

  22. TYPO3com voted on patch set 9 V -1 03/01/18, 16:56 Completed build in 09s on Thu, 1 Mar, 05:56 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20378

  23. Christian Kuhn abandoned the change 09/16/18, 22:20

    hey. nothing happened here for > half a year. i'll take the freedom do abandon this patch for now for the sake of a more clean review queue. please feel free to bring this up again if you feel so.