Review main Abandoned

51069[BUGFIX] Fix first domain selection in BackendUtility

Matthias Toscanelli CR 0 V 0 Easy +1 −1 updated 02/25/17, 16:18

Commit message

"BackendUtility:getRecordsByField" returns an empty array if no domain
has been found for the page. We have to check that the return value is
a non-empty array.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 78

  1. Matthias Toscanelli uploaded patch set 1 12/30/16, 12:30

  2. TYPO3com voted on patch set 1 V +1 12/30/16, 12:34 Completed build in 04m 26s on Fri, 30 Dec, 01:34 PM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6067

  3. Tymoteusz Motylewski commented on patch set 1 12/30/16, 19:18

    What happens without the patch? an warning/notice is thrown? Is the error visible somewhere in the backend? Does the issue also exist in TYPO3 7.6?
  4. Matthias Toscanelli commented on patch set 1 01/12/17, 08:40

    I will write some tests on version 8.5 and 7.6 to see what error I get
  5. Mona Muzaffar commented on patch set 1 02/24/17, 15:18

    i don't think this patch is valid after this : https://review.typo3.org/51078 was merged. Does the bug still exist oder can this be closed?
  6. Mona Muzaffar commented on patch set 1 02/24/17, 15:19

    > i don't think this patch is valid after this : https://review.typo3.org/51078 > was merged. Does the bug still exist oder can this be closed? or* can this be closed?
  7. Matthias Toscanelli commented on patch set 1 02/25/17, 14:40

    I am agree with you, this patch is correcting this bug. We can close this issue
  8. Wouter Wolters abandoned the change 02/25/17, 16:18

    solved