Review main Merged

51152[TASK] Extend Testbase to run functionals tests with multiple DB drivers

Manuel Selbach CR +2 V +2 Normal +56 −4 updated 02/15/17, 13:07

Commit message

Implement Testbase::importXmlDatabaseFixtureFinisher to handle database
platform specific cleanup tasks for functional tests. For PostgreSQL
this will update the primary key sequences to the maximum value used
in the table to avoid key errors on subsquent inserts.

This patch doesn't fix all functional test to work on PostgreSQL, this
will follow in smaller, subsequent patches as many tests currently fail
due to database rows being returned in a different order as well as
due to different return types of the databases (i.e. int vs. string)
leading to failures when using assertSame().

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1