Review main Merged

51242[BUGFIX] Make date/time fields working again

Dominique Kreemers CR +2 V +2 Hard +188 −207 updated 06/09/17, 13:28

Commit message

This patch solves an issue with time-fields and a couple of
inconsistencies for time(sec), date and datetime fields in BE:

- BackendUtility::time() is superfluous as gmdate() can be used
- Ensure stored data is identical to TYPO3 7
- Only use ISO dates in UTC timezone to communicate with JS
  (time fields use 1970-01-01 as date)
- Only write ISO dates in UTC back to hidden FormEngine fields
- Do that for all date/time fields to simplify JS code
- Take care of necessary timezone conversion for date(time) fields
- Correctly handle manual input
- Fix record titles if a date field is the label field
- Fix wrong Acceptance tests
- Fix wrong Unit tests
- Remove superfluous data-date-offset attribute for DateTimePicker
- Streamline FormEngineValidation date handling code
- Refactor DateTimePicker: fix code duplication, work in UTC only

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 14