Review main Merged

51270[BUGFIX] ResourceCompressor does not persist external resources

Benni Mack CR +2 V +2 Easy +2 −2 updated 01/11/17, 20:27

Commit message

The condition in the ResourceCompressor for fetching
external files never worked, as it was a simple typo
to update an external resource.

So the first time the local file did not exist (and thus, the md5
did not match) and the file was fetched but due to the
wrong check, the file never got updated.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • David Greiner +1
  • Verified V +2
    • Christian Kuhn +2
    • David Greiner +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Benni Mack uploaded patch set 1 01/11/17, 17:05

  2. TYPO3com voted on patch set 1 V +1 01/11/17, 17:10 Completed build in 04m 54s on Wed, 11 Jan, 06:10 PM Test Summary: 54945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6504

  3. David Greiner voted on patch set 1 CR +1 01/11/17, 17:54

  4. David Greiner voted on patch set 1 V +1 01/11/17, 17:55

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 01/11/17, 20:27

  6. Gerrit merged patch set 1 01/11/17, 20:27