Review main Merged

51306[FEATURE] Make thumbnail size in file list configurable

Alexander Schnitzler CR +2 V +2 Normal +139 −3 updated 10/06/17, 10:21

Commit message

The size of thumbnails of the file list is hard coded to
64x64 px which might not be optimal in some cases. Thus,
the size should be configurable via UserTS.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Benni Mack +2
    • Georg Ringer +1
    • Markus Sommer +1
    • Jörg Bösche +1
  • Verified V +2
    • Christian Kuhn +2
    • Georg Ringer +1
    • Markus Sommer +1
    • Riccardo De Contardi +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 3035

Show 710 earlier messages
  1. Alexander Schnitzler uploaded patch set 1 01/13/17, 14:22

  2. TYPO3com voted on patch set 1 V +1 01/13/17, 14:27 Completed build in 05m 24s on Fri, 13 Jan, 03:27 PM Test Summary: 54939 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6622

  3. Frans Saris commented on patch set 1 CR -1 V +1 01/15/17, 11:19

    Could you add a rst file
    UserTS?
  4. Alexander Schnitzler rebased onto patch set 2 02/11/17, 10:51

  5. TYPO3com voted on patch set 2 V +1 02/11/17, 10:56 Completed build in 04m 45s on Sat, 11 Feb, 11:56 AM Test Summary: 56213 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7925

  6. Alexander Schnitzler uploaded patch set 3 02/11/17, 10:59

  7. TYPO3com voted on patch set 3 V +1 02/11/17, 11:05 Completed build in 05m 13s on Sat, 11 Feb, 12:05 PM Test Summary: 56213 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7926

  8. Riccardo De Contardi voted on patch set 3 V +1 02/11/17, 11:08

  9. Jörg Bösche voted on patch set 3 CR +1 02/23/17, 18:42

  10. Georg Ringer commented on patch set 3 CR -2 02/23/17, 18:52

    don't invest time please currently into testing features as those will be merged when development of 9x starts!
  1. Alexander Schnitzler commented on patch set 3 02/24/17, 09:17

    So, there will not be any features for 8.7 anymore? Can hardly believe that the next 2 months there will only be bugfixes...
  2. Josef Glatz commented on patch set 4 02/24/17, 09:59

    Published edit on patch set 3.
  3. Georg Ringer commented on patch set 4 02/24/17, 12:34

    you can ask benni for exceptions but as there will be soon the 9 with sprint releases, it will be in the core soon
  4. Tymoteusz Motylewski commented on patch set 4 07/03/17, 20:51

    Georg, can you remove the -2, so we can get it in?
  5. Georg Ringer voted on patch set 4 CR 0 07/04/17, 07:13

  6. Tymoteusz Motylewski commented on patch set 4 CR -1 07/04/17, 07:34

    at last one more place is missing - the search view in file list and maybe in file selector
  7. Alexander Schnitzler commented on patch set 4 09/14/17, 13:32

    @Tymek Can you remove the -1 and give the patch a chance? It was ready to be merged in 8.7, now it's blocked. It might not cover all necessary parts but the patch itself, just like it is, works and is an improvement.
  8. Tymoteusz Motylewski commented on patch set 4 09/14/17, 14:54

    I think the patch should cover all places together, as it will be confusing to the user to see different behaviour when browsing filelist and when searching in filelist. It should not be a big deal to implement the missing part. If others don't agree with me, my -1 can be still overridden by +2
  9. Alexander Schnitzler uploaded patch set 5 09/15/17, 17:35

  10. Alexander Schnitzler commented on patch set 5 09/15/17, 17:35

    Just a rebase for now.
  11. TYPO3com voted on patch set 5 V +1 09/15/17, 17:51 Completed build in 15m 53s on Fri, 15 Sep, 07:51 PM Test Summary: 58092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14957

  12. Alexander Schnitzler uploaded patch set 6 09/15/17, 18:15

  13. TYPO3com voted on patch set 6 V +1 09/15/17, 18:32 Completed build in 16m 34s on Fri, 15 Sep, 08:32 PM Test Summary: 58091 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14958

  14. Riccardo De Contardi commented on patch set 6 V +1 09/15/17, 18:49

    tested with both usergroup and user TSconfig
  15. Jörg Bösche voted on patch set 6 CR +1 09/17/17, 10:02

  16. Alexander Schnitzler wrote 09/20/17, 06:48

    Topic set to UX
  17. Wouter Wolters commented on patch set 6 09/20/17, 06:55

    ThumbnailConfiguration.php:38

    missing phpdoc
  18. Alexander Schnitzler commented on patch set 6 09/20/17, 08:14

    ThumbnailConfiguration.php:38 Reply

    What do we need a phpdoc for? No arguments, no return type, no java. :P
  19. Alexander Schnitzler commented on patch set 6 10/05/17, 14:33

    Ping
  20. Benni Mack voted on patch set 6 CR +2 10/05/17, 16:06

  21. Georg Ringer voted on patch set 6 CR +1 V +1 10/06/17, 08:53

  22. Christian Kuhn commented on patch set 6 10/06/17, 10:12

    while we can do this now, i'd just like to add some words from benji here: he basically wants to make the file list module switchable between a list- and a thumbnail/image view - as know from file browsers. this would maybe render this setting useless or less helpful again. never the less, we could imho do this change here until this happens.
  23. Markus Sommer commented on patch set 6 CR +1 V +1 10/06/17, 10:21

    Work great :)
  24. Christian Kuhn voted on patch set 6 CR +2 V +2 10/06/17, 10:21

  25. Gerrit merged patch set 6 10/06/17, 10:21