Review main Merged

51320[BUGFIX] Extbase: Fix counting objects on joined tables

Morton Jonuschat CR +2 V +2 Easy +32 −7 updated 01/27/17, 12:11

Commit message

While it's normally fine to replace DISTINCT with GROUP BY when counting
objects this results in a different resultset. The GROUP BY statement will
have n rows with the count per grouped combination while the DISTINCT
based query will have one row with the count of unique combinations.

Use a COUNT(DISTINCT uid) to get the expected result. 
DISTINCT is supported on MySQL, PostgreSQL, Oracle and MSSQL Server.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 4