Review main Merged

51380[FEATURE] Auto-render and attach HeaderAssets and FooterAssets

Claus Due CR +2 V +2 Normal +151 −0 updated 02/06/17, 19:58

Commit message

This patch adds a new method on ActionController,
initializeAssetsForRequest($request) which comes
with a default implementation and allows overriding
in subclasses.

The default implementation of this new feature will
try to render sections HeaderAssets and FooterAssets
from the Fluid template that is resolved, assigning
the output (if not empty) to either header or footer,
by using the PageRenderer.

The feature only works for TemplateView and
subclasses thereof, since `renderSection` is not a
required method for ViewInterface implementations;
it only exists on the (MVC-centric) TemplateView.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3