Review main Merged

51386[TASK] Improve constant editor

Georg Ringer CR +2 V +2 Easy +13 −10 updated 01/26/17, 15:17

Commit message

- Skip length check of header
- Use type "number" for integer types
- Apply min & max attributes if available

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Mattias Nilsson +1
    • Benni Mack +1
  • Verified V +2
    • Christian Kuhn +2
    • Mattias Nilsson +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 810

  1. Georg Ringer uploaded patch set 1 01/22/17, 20:17

  2. TYPO3com voted on patch set 1 V +1 01/22/17, 20:22 Completed build in 04m 58s on Sun, 22 Jan, 09:22 PM Test Summary: 55161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6896

  3. Benni Mack commented on patch set 2 01/23/17, 05:42

    Published edit on patch set 1.
  4. Benni Mack voted on patch set 2 CR +1 01/23/17, 05:42

  5. TYPO3com voted on patch set 2 V +1 01/23/17, 05:47 Completed build in 05m 03s on Mon, 23 Jan, 06:47 AM Test Summary: 55161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6905

  6. Wouter Wolters voted on patch set 2 CR +1 01/23/17, 09:19

  7. Mattias Nilsson voted on patch set 2 CR -1 V -1 01/26/17, 06:53

  8. Mattias Nilsson voted on patch set 2 CR +1 V +1 01/26/17, 08:01

  9. Christian Kuhn commented on patch set 2 CR +2 V +2 01/26/17, 15:17

    example: # cat=plugin.tx_news/file; type=int [0-5]; foo = 2
  10. Gerrit merged patch set 2 01/26/17, 15:17