51400[TASK] Use normalized jpg_quality in GraphicalFunctions
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Benni Mack +2
- Wouter Wolters +1
- Andreas Kienast +1
-
Verified V +2
- Georg Ringer +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1113
-
Sascha Egerer uploaded patch set 1 01/23/17, 13:49
-
Wouter Wolters updated the commit message in patch set 2 01/23/17, 13:51
-
Wouter Wolters voted on patch set 2 CR +1 01/23/17, 13:51
-
TYPO3com voted on patch set 1 V +1 01/23/17, 13:56 Completed build in 06m 52s on Mon, 23 Jan, 02:56 PM Test Summary: 55161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6935
-
TYPO3com voted on patch set 2 V +1 01/23/17, 13:59 Completed build in 07m 21s on Mon, 23 Jan, 02:59 PM Test Summary: 55161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6937
-
Andreas Kienast commented on patch set 2 01/23/17, 15:02
7.6 is affected was well. Backport? -
Sascha Egerer commented on patch set 2 01/23/17, 19:00
It's more like a cleanup so I would not backport it. This can only be a problem if you have an invalid configuration. -
Tymoteusz Motylewski commented on patch set 2 01/23/17, 19:21
any hints how to test it? -
Sascha Egerer commented on patch set 2 01/29/17, 13:37
@Tymoteusz There is no real test case for that as it's just a cleanup task. You can test it by setting GFX/processor_effects = 1 and GFX/jpg_quality = 1. Then create a content element with an jpg image and check the resulting image which should be very ugly. Then set the jpg_quality = 10 and check that the result is better. When apply the patch the jpg_quality = 1 should have no effect as the lowest possible value is 10. You can also check the resulting image magick commands executed by `GraphicalFunctions::imageMagickExec()` -
Andreas Kienast voted on patch set 2 CR +1 01/29/17, 19:24
-
Benni Mack commented on patch set 2 CR +2 V +1 01/30/17, 12:35
everything still works as expected. -
Georg Ringer voted on patch set 2 CR +2 V +2 01/30/17, 19:28
-
Gerrit merged patch set 2 01/30/17, 19:28