Review main Merged

51400[TASK] Use normalized jpg_quality in GraphicalFunctions

Sascha Egerer CR +2 V +2 Easy +1 −1 updated 01/30/17, 19:28

Commit message

If the setting 'processor_effects' is set the already normalized
value of jpg_quality should be used.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Andreas Kienast +1
  • Verified V +2
    • Georg Ringer +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1113

  1. Sascha Egerer uploaded patch set 1 01/23/17, 13:49

  2. Wouter Wolters updated the commit message in patch set 2 01/23/17, 13:51

  3. Wouter Wolters voted on patch set 2 CR +1 01/23/17, 13:51

  4. TYPO3com voted on patch set 1 V +1 01/23/17, 13:56 Completed build in 06m 52s on Mon, 23 Jan, 02:56 PM Test Summary: 55161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6935

  5. TYPO3com voted on patch set 2 V +1 01/23/17, 13:59 Completed build in 07m 21s on Mon, 23 Jan, 02:59 PM Test Summary: 55161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6937

  6. Andreas Kienast commented on patch set 2 01/23/17, 15:02

    7.6 is affected was well. Backport?
  7. Sascha Egerer commented on patch set 2 01/23/17, 19:00

    It's more like a cleanup so I would not backport it. This can only be a problem if you have an invalid configuration.
  8. Tymoteusz Motylewski commented on patch set 2 01/23/17, 19:21

    any hints how to test it?
  9. Sascha Egerer commented on patch set 2 01/29/17, 13:37

    @Tymoteusz There is no real test case for that as it's just a cleanup task. You can test it by setting GFX/processor_effects = 1 and GFX/jpg_quality = 1. Then create a content element with an jpg image and check the resulting image which should be very ugly. Then set the jpg_quality = 10 and check that the result is better. When apply the patch the jpg_quality = 1 should have no effect as the lowest possible value is 10. You can also check the resulting image magick commands executed by `GraphicalFunctions::imageMagickExec()`
  10. Andreas Kienast voted on patch set 2 CR +1 01/29/17, 19:24

  11. Benni Mack commented on patch set 2 CR +2 V +1 01/30/17, 12:35

    everything still works as expected.
  12. Georg Ringer voted on patch set 2 CR +2 V +2 01/30/17, 19:28

  13. Gerrit merged patch set 2 01/30/17, 19:28