Review main Merged

51521[TASK] Do not throw exception on unavailable APC(u) cache backend

Thorsten Bringewatt CR +2 V +2 Easy +7 −2 updated 05/11/17, 19:06

Commit message

Log an error (keeping the website available) instead of throwing an
exception (and thus completely disabling it) if TYPO3 is configured to
use the APC / APCu cache backend but saving data to the cache failed.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Alexander Opitz +1
    • Stephan Großberndt +1
  • Verified V +2
    • Christian Kuhn +2
    • Alexander Opitz +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1823

  1. Thorsten Bringewatt uploaded patch set 1 02/03/17, 14:56

  2. TYPO3com voted on patch set 1 V -1 02/03/17, 16:15 Completed build in 06m 26s on Fri, 3 Feb, 05:15 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7402

  3. Christian Kuhn rebased onto patch set 2 02/03/17, 16:16

  4. TYPO3com voted on patch set 2 V +1 02/03/17, 16:31 Completed build in 13m 44s on Fri, 3 Feb, 05:31 PM Test Summary: 55901 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7409

  5. Andreas Kienast commented on patch set 2 CR -1 02/03/17, 22:51

    Ticket is missing
  6. Georg Ringer updated the commit message in patch set 3 02/06/17, 06:27

  7. Georg Ringer voted on patch set 3 CR +1 V +1 02/06/17, 06:27

  8. TYPO3com voted on patch set 3 V +1 02/06/17, 06:34 Completed build in 06m 50s on Mon, 6 Feb, 07:34 AM Test Summary: 55955 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7538

  9. Thomas Hohn voted on patch set 3 CR +1 02/06/17, 06:35

  10. Stephan Großberndt commented on patch set 4 02/06/17, 09:48

    Published edit on patch set 3.
  11. Stephan Großberndt voted on patch set 4 CR +1 02/06/17, 09:50

  12. TYPO3com voted on patch set 4 V +1 02/06/17, 09:53 Completed build in 04m 35s on Mon, 6 Feb, 10:53 AM Test Summary: 55955 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7553

  13. Stefan Neufeind voted on patch set 4 CR +1 04/03/17, 13:48

  14. Alexander Opitz commented on patch set 4 CR +1 V +1 05/09/17, 15:25

    Would also vote for backporting to 8 LTS
  15. Stephan Großberndt updated the commit message in patch set 5 05/09/17, 15:26

  16. Stephan Großberndt voted on patch set 5 CR +1 05/09/17, 15:27

  17. Stefan Neufeind voted on patch set 5 CR +1 05/09/17, 15:28

  18. TYPO3com voted on patch set 5 V +1 05/09/17, 15:32 Completed build in 05m 51s on Tue, 9 May, 05:32 PM Test Summary: 55794 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11316

  19. Alexander Opitz voted on patch set 5 CR +1 V +1 05/09/17, 17:11

  20. Elmar Hinz commented on patch set 5 05/11/17, 16:23

    Does this failure indicate runtime instability of the cache or misconfiguration? IMHO that makes a difference. The first case should be logged. The second case should cry for fixing.
  21. Christian Kuhn commented on patch set 5 CR +2 V +2 05/11/17, 19:04

    Elmar, in my experience, that happens from time to time, even if the apc / apcu configuration is ok. it seems sometimes set() just does not suceed, for whatever reason. setting again then works. Configuration errors (like not loaded php module or broken settings) are checked before already. Thus, I'd say the patch is fine: Do not except, instead log, just because apc / apcu as 3rd party software isn't 100% stable in all cases but only 99,999% or whatever. Administrators only need to act if the log is really full of those errors, I'd guess.
  22. Gerrit merged patch set 5 05/11/17, 19:05

  23. Christian Kuhn commented on patch set 6 05/11/17, 19:06

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 1aa85df224375f8d54cde4c6033013011dcedf74