Review main Merged

51554[BUGFIX] Fix CGL script to new return status strategy of php-cs-fixer

Wouter Wolters CR +2 V +2 Easy +9 −2 updated 02/07/17, 20:55

Commit message

Status codes are only returned when running in dry-run mode.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2
    • Andreas Kienast +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 2028

Show 23 earlier messages
  1. Wouter Wolters uploaded patch set 1 02/06/17, 12:00

  2. TYPO3com voted on patch set 1 V -1 02/06/17, 12:00 Completed build in 06s on Mon, 6 Feb, 01:00 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7572

  3. Wouter Wolters rebased onto patch set 2 02/06/17, 12:02

  1. Wouter Wolters uploaded patch set 3 02/06/17, 12:03

  2. TYPO3com voted on patch set 2 V +1 02/06/17, 12:09 Completed build in 06m 51s on Mon, 6 Feb, 01:09 PM Test Summary: 55955 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7573

  3. TYPO3com voted on patch set 3 V +1 02/06/17, 12:11 Completed build in 07m 29s on Mon, 6 Feb, 01:11 PM Test Summary: 55955 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7574

  4. Philipp Gampe voted on patch set 3 CR +1 02/06/17, 12:16

  5. Andreas Kienast voted on patch set 3 CR +1 02/06/17, 12:26

  6. Tymoteusz Motylewski commented on patch set 3 CR -1 V -1 02/06/17, 14:38

    cglFixMyCommit.sh:17

    this should be "$1" shouln't it? I'm getting "typo3/sysext/core/Build/Scripts/cglFixMyCommit.sh: line 17: [: =: unary operator expected"
  7. Wouter Wolters rebased onto patch set 4 02/07/17, 20:24

  8. Wouter Wolters commented on patch set 5 02/07/17, 20:28

    Published edit on patch set 4.
  9. Andreas Kienast voted on patch set 5 CR +1 02/07/17, 20:30

  10. TYPO3com voted on patch set 4 V +1 02/07/17, 20:31 Completed build in 06m 07s on Tue, 7 Feb, 09:31 PM Test Summary: 56147 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7738

  11. Andreas Kienast voted on patch set 5 V +1 02/07/17, 20:32

  12. TYPO3com voted on patch set 5 V +1 02/07/17, 20:35 Completed build in 07m 07s on Tue, 7 Feb, 09:35 PM Test Summary: 56195 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7740

  13. Christian Kuhn commented on patch set 5 CR -1 02/07/17, 20:41

    gimme some test pushes to see if that works on bamboo.
  14. Christian Kuhn uploaded patch set 6 02/07/17, 20:44

  15. Christian Kuhn commented on patch set 6 02/07/17, 20:45

    this patch set should make bamboo red, now.
  16. Christian Kuhn voted on patch set 6 CR -1 02/07/17, 20:45

  17. Christian Kuhn uploaded patch set 7 02/07/17, 20:46

  18. Christian Kuhn commented on patch set 7 02/07/17, 20:47

    and set 7 should be green again by bamboo.
  19. TYPO3com voted on patch set 6 V -1 02/07/17, 20:51 Completed build in 06m 16s on Tue, 7 Feb, 09:51 PM Test Summary: 1 of 56195 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7745

  20. TYPO3com voted on patch set 7 V -1 02/07/17, 20:52 Completed build in 05m 22s on Tue, 7 Feb, 09:52 PM Test Summary: 1 of 56195 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7746

  21. TYPO3com voted on patch set 7 V +1 02/07/17, 20:54 Completed build in 12m 36s on Tue, 7 Feb, 09:54 PM Test Summary: 56195 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7746

  22. Christian Kuhn voted on patch set 7 CR +1 V +1 02/07/17, 20:54

  23. Andreas Kienast voted on patch set 7 CR +2 V +2 02/07/17, 20:55

  24. Gerrit merged patch set 7 02/07/17, 20:55

  25. Andreas Kienast commented on patch set 8 02/07/17, 20:55

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit e0182df0c49bea81d86bc275d46ce0867699814a