Review main Merged

51571[TASK] Add common image ratio 3:2 to cropVariants

Josef Glatz CR +2 V +2 Easy +7 −0 updated 02/09/17, 07:40

Commit message

In addition to 16:9, 4:3, 1:1 and free another common
image ratio "3:2" (DSLR default format) is introduced.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Harry Glatz +1
    • Georg Ringer +1
    • Wouter Wolters +1
    • Alexander Grein +1
  • Verified V +2
    • Andreas Kienast +2
    • Harry Glatz +1
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1113

  1. Josef Glatz uploaded patch set 1 02/08/17, 08:19

  2. TYPO3com voted on patch set 1 V -1 02/08/17, 08:24 Completed build in 05m 09s on Wed, 8 Feb, 09:24 AM Test Summary: 1 of 56225 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7768

  3. Wouter Wolters commented on patch set 1 02/08/17, 09:20

    in addition to 3:2 we add 3:2 again? :-P
  4. Josef Glatz updated the commit message in patch set 2 02/08/17, 09:20

  5. Josef Glatz commented on patch set 2 02/08/17, 09:21

    pfff @wouter ;-P thx ^^
  6. TYPO3com voted on patch set 2 V +1 02/08/17, 09:27 Completed build in 06m 04s on Wed, 8 Feb, 10:27 AM Test Summary: 56225 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7770

  7. Wouter Wolters commented on patch set 2 CR +1 02/08/17, 09:34

  8. Alexander Grein voted on patch set 2 CR +1 02/08/17, 11:17

  9. Helmut Hummel commented on patch set 2 02/08/17, 12:19

    fine with me
  10. Georg Ringer voted on patch set 2 CR +1 V +1 02/09/17, 02:08

  11. Harry Glatz voted on patch set 2 CR +1 V +1 02/09/17, 07:14

  12. Andreas Kienast voted on patch set 2 CR +2 V +2 02/09/17, 07:40

  13. Gerrit merged patch set 2 02/09/17, 07:40