Review main Merged

51597[BUGFIX] Page module: fix bottom margin of language header

Josef Glatz CR +2 V +2 Easy +2 −2 updated 02/09/17, 00:19

Commit message

Add missing `bottom-margin` by only overriding `margin-top`
of generic `h2` style.

Review

  • Code review CR +2
    • Markus Klein +2
    • Michael Oehlhof +1
  • Verified V +2
    • Markus Klein +2
    • Riccardo De Contardi +1
    • Michael Oehlhof +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 67

  1. Josef Glatz uploaded patch set 1 02/08/17, 22:55

  2. Josef Glatz commented on patch set 1 02/08/17, 22:58

    See before/after screenshot in the issue itself :-) https://forge.typo3.org/issues/79699#Acceptance-Criteria
  3. TYPO3com voted on patch set 1 V +1 02/08/17, 23:00 Completed build in 05m 18s on Thu, 9 Feb, 12:00 AM Test Summary: 56225 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7810

  4. Riccardo De Contardi voted on patch set 1 V +1 02/08/17, 23:19

  5. Michael Oehlhof voted on patch set 1 CR +1 V +1 02/08/17, 23:47

  6. Markus Klein voted on patch set 1 CR +2 V +2 02/09/17, 00:19

  7. Gerrit merged patch set 1 02/09/17, 00:19