Review main Merged

51620[BUGFIX] Flaky unit tests FrontendUserAuthentication

Christian Kuhn CR +2 V +2 Hard +294 −119 updated 02/09/17, 23:51

Commit message

Unit testing user authentication is still a mess since the class
does way too much to be well testable.
The patch refactors a number of tests that came in with the session
framework test to not rely on mocked $subject anymore, but it also
marks a couple of tests to be skipped for now - those should be
transferred to functional tests which will probably end up to be
much easier to understand and maintainable.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 1